Fix active state mapping in wolflink

mtielen commented 2 weeks ago

Breaking change

Proposed change

Fixes a typo which prevents the active state from being displayed.

Type of change

[ ] Dependency upgrade
[X] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[X] The code change is tested and works locally.
[X] Local tests pass. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[X] I have followed the development checklist
[X] I have followed the perfect PR recommendations
[X] The code has been formatted using Ruff (ruff format homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

[X] I have reviewed two other open pull requests in this repository.

home-assistant[bot] commented 2 weeks ago

Hey there @adamkrol93, mind taking a look at this pull request as it has been labeled with an integration (wolflink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `wolflink` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign wolflink` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

davet2001 commented 2 weeks ago

Please can you give some reasoning for the poll interval change you added after review?

mtielen commented 2 weeks ago

Please can you give some reasoning for the poll interval change you added after review?

Hi @davet2001, as this merge request was still open I thought it was more efficient to combine it. Sorry it's just my second PR if this should not have been done. I just restored the value to it's orginal from the orginal code as the API even supports every 10 seconds as the website is doing. Let me know if I need to retrigger something.

davet2001 commented 2 weeks ago

Hi @mtielen thanks for contributing!

It's usually best to put things in separate PRs unless they need to be linked.

For example I can review and merge the PR relating to the typo easily. But if you are shortening a poll interval, then the reviewer needs to check that you aren't hitting a rate limit somewhere, unexpectedly affecting something else, and probably do a bit of digging to work out why it was set to 90 originally, etc etc.

But since there was no mention of it in the PR description, my first check was to make sure it was intentional!

Please revert the poll interval change and open that in a new PR if wanted.

mtielen commented 2 weeks ago

Hi @mtielen thanks for contributing!

It's usually best to put things in separate PRs unless they need to be linked.

For example I can review and merge the PR relating to the typo easily. But if you are shortening a poll interval, then the reviewer needs to check that you aren't hitting a rate limit somewhere, unexpectedly affecting something else, and probably do a bit of digging to work out why it was set to 90 originally, etc etc.

But since there was no mention of it in the PR description, my first check was to make sure it was intentional!

Please revert the poll interval change and open that in a new PR if wanted.

Hi @davet2001, Thanks for helping me here. I'm sorry for the extra work. I reverted the commit and will open a new PR for reverting the poll interval to it's original value.

davet2001 commented 2 weeks ago

Looks good, thanks @mtielen!

mtielen commented 2 weeks ago

Looks good, thanks @mtielen!

Thanks @davet2001 for your help

home-assistant / core