home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.03k stars 28.28k forks source link

Allow reconfiguration of integration sensor #116740

Closed elupus closed 1 week ago

elupus commented 2 weeks ago

Proposed change

Allow changing a riemann sum integral after it's been added from config flow.

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 2 weeks ago

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (integration) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `integration` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign integration` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
dgomes commented 2 weeks ago

I'm OK with adding an option to change the integration method, but:

elupus commented 2 weeks ago

It very easy to get wrong when you initially add it. Also replacing the source sensor is allowed for stuff like group helpers, so see no reason not to add it.

elupus commented 1 week ago

I have removed the scaling and time unit config, as well as making sure the new entity is selected has a compatible unit of measurement.

home-assistant[bot] commented 1 week ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.