home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.03k stars 28.28k forks source link

Switch to use reported events for integral #116742

Closed elupus closed 2 weeks ago

elupus commented 2 weeks ago

Breaking change

Calculation of reimann sum may change slightly since it now takes into consideration same state events.

Proposed change

Riemann integrals now update based on reported events from it's monitored state instead of on changes. This allow static values to increment the riemann sum.

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 2 weeks ago

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (integration) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `integration` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign integration` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
ronweikamp commented 2 weeks ago

There was already an attempt to switch the integral to state_reported events https://github.com/home-assistant/core/pull/113869 . Consider closing.

elupus commented 2 weeks ago

Closed as duplicate of https://github.com/home-assistant/core/pull/113869