home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.03k stars 28.27k forks source link

Store Tractive data in `config_entry.runtime_data` #116781

Closed bieniu closed 1 week ago

bieniu commented 2 weeks ago

Breaking change

Proposed change

Store Tractive data in config_entry.runtime_data.

EDIT: I added tests for the diagnostics platform so that codecov would not complain.

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 2 weeks ago

Hey there @danielhiversen, @zhulik, mind taking a look at this pull request as it has been labeled with an integration (tractive) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `tractive` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign tractive` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
bieniu commented 1 week ago

Codecov complains about lack of tests for the diagnostics platform and pre-commit doesn’t allow to add diagnostics.py to the .codecovrc. Tests for the diagnostics platform are mandatory?