Closed bdraco closed 1 week ago
Hey there @hacf-fr, @quentame, @mib1185, mind taking a look at this pull request as it has been labeled with an integration (synology_dsm
) you are listed as a code owner for? Thanks!
tested by manually disconnect established session on Synology
2024-05-05 09:23:37.982 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Start data update for '21B0R2RQ4TNT0'
2024-05-05 09:23:38.003 DEBUG (MainThread) [homeassistant.components.synology_dsm.coordinator] login is expired, try to login again
2024-05-05 09:23:38.650 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Start data update for '21B0R2RQ4TNT0'
2024-05-05 09:23:39.975 DEBUG (MainThread) [homeassistant.components.synology_dsm.coordinator] Finished fetching 192.168.100.200 SynologyDSMCentralUpdateCoordinator data in 1.993 seconds (success: True)
Proposed change
Ensure all synology_dsm coordinators handle expired sessions as only the main coordinator did.
seen in https://github.com/home-assistant/core/issues/116755#issuecomment-2094076518
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: