home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.03k stars 28.28k forks source link

Store runtime data inside the config entry in Radio Browser #116821

Closed mib1185 closed 1 week ago

mib1185 commented 1 week ago

Proposed change

SSIA

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 1 week ago

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (radio_browser) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `radio_browser` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign radio_browser` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
mib1185 commented 1 week ago

mehhh ... there were no tests for media_source.py before, but adding it to .coveragerc is declined by hassfest 🙄

hassfest.................................................................Failed
- hook id: hassfest
- exit code: 1
[...]
Integrations: 1261
Invalid integrations: 1

Found errors. Generating files canceled.

Integration radio_browser:
* [ERROR] [COVERAGE] media_source.py must not be ignored by the .coveragerc file