home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.03k stars 28.28k forks source link

Custom forecast #116826

Open kamiyo opened 1 week ago

kamiyo commented 1 week ago

Proposed change

A WIP to allow comment for allowing extra attributes back into the weather forecast, this time as a dict on extra_attributes attribute. Right now, the weather template limits the attributes forecasts can return, but many services return useful and interesting data (for example, it is possible from NWS to get chance of thunderstorm, wet bulb temperature, etc.). Another attribute name could be used instead of extra_attributes. I thought about extended, but in the context of a forecast, that sounds like an extended timescale. Maybe extra_attr.

I am also unsure about the reason for the strict attribute validation in forecasts.

Integrations that already returned extra attributes prior to the current version of the template will be able to reincorporate those attributes under the extra attribute (so will have to be rewritten, but those broke anyways with the current template validation). This was passionately debated here: #114799

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 1 week ago

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (weather) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `weather` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign weather` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
home-assistant[bot] commented 1 week ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.