Open kamiyo opened 1 week ago
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (weather
) you are listed as a code owner for? Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Proposed change
A WIP to allow comment for allowing extra attributes back into the weather forecast, this time as a dict on
extra_attributes
attribute. Right now, the weather template limits the attributes forecasts can return, but many services return useful and interesting data (for example, it is possible from NWS to get chance of thunderstorm, wet bulb temperature, etc.). Another attribute name could be used instead ofextra_attributes
. I thought aboutextended
, but in the context of a forecast, that sounds like an extended timescale. Maybeextra_attr
.I am also unsure about the reason for the strict attribute validation in forecasts.
Integrations that already returned extra attributes prior to the current version of the template will be able to reincorporate those attributes under the
extra
attribute (so will have to be rewritten, but those broke anyways with the current template validation). This was passionately debated here: #114799Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: