home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.03k stars 28.28k forks source link

Add ZHA XZG firmware discovery #116828

Open xyzroe opened 1 week ago

xyzroe commented 1 week ago

Proposed change

Add XZG Firmware ZeroConf to ZHA. Tested locally

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 1 week ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] commented 1 week ago

Hey there @dmulcahey, @adminiuga, @puddly, @thejulianjes, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `zha` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign zha` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
Hedda commented 2 days ago

If user exposed functionality or configuration variables are added/changed:

@xyzroe suggest also submit PR to next branch of zha documentation for the home-assistant.io repository:

https://www.home-assistant.io/integrations/zha/#discovery-via-usb-or-zeroconf

https://github.com/home-assistant/home-assistant.io/blob/next/source/_integrations/zha.markdown

puddly commented 2 days ago

Is this firmware in use by any devices yet? If not, let's hold off on merging this PR because I would like to steer future TCP coordinators to use a general _zigbee.local. type. That way, you will not need to make a PR every time a new coordinator type comes out.

xyzroe commented 1 day ago

Some users have already updated their devices to this firmware. Everyone would like to use it already.
And of course it is possible to add general type, and users will quickly update. When this feature is expected?