Open xyzroe opened 1 week ago
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Hey there @dmulcahey, @adminiuga, @puddly, @thejulianjes, mind taking a look at this pull request as it has been labeled with an integration (zha
) you are listed as a code owner for? Thanks!
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
@xyzroe suggest also submit PR to next branch of zha documentation for the home-assistant.io repository:
https://www.home-assistant.io/integrations/zha/#discovery-via-usb-or-zeroconf
https://github.com/home-assistant/home-assistant.io/blob/next/source/_integrations/zha.markdown
Is this firmware in use by any devices yet? If not, let's hold off on merging this PR because I would like to steer future TCP coordinators to use a general _zigbee.local.
type. That way, you will not need to make a PR every time a new coordinator type comes out.
Some users have already updated their devices to this firmware. Everyone would like to use it already.
And of course it is possible to add general type, and users will quickly update. When this feature is expected?
Proposed change
Add XZG Firmware ZeroConf to ZHA. Tested locally
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: