Avoid duplicate data fetch during Synologs DSM setup

mib1185 commented 1 week ago

Proposed change

we already setup the api in

https://github.com/home-assistant/core/blob/f5394dc3a3d023b3cb22dafc8d8435679fcda408/homeassistant/components/synology_dsm/__init__.py#L66-L69

so the first data fetch of the central coordinator is not needed and just leads to a duplicated fetch of all data at startup

prior this change:

2024-05-05 08:53:31.194 INFO (MainThread) [homeassistant.setup] Setting up synology_dsm
2024-05-05 08:53:32.106 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] State of Surveillance_station during setup of '21B0R2RQ4TNT0': False
2024-05-05 08:53:32.200 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable security api updates for '21B0R2RQ4TNT0'
2024-05-05 08:53:32.201 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable photos api updates for '21B0R2RQ4TNT0'
2024-05-05 08:53:32.201 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable storage api updates for '21B0R2RQ4TNT0'
2024-05-05 08:53:32.201 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable upgrade api updates for '21B0R2RQ4TNT0'
2024-05-05 08:53:32.201 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable system api updates for '21B0R2RQ4TNT0'
2024-05-05 08:53:32.201 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable utilisation api updates for '21B0R2RQ4TNT0'
2024-05-05 08:53:32.201 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Start data update for '21B0R2RQ4TNT0'
2024-05-05 08:53:32.201 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Entities not added yet, fetch all for '21B0R2RQ4TNT0'
2024-05-05 08:53:39.273 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Start data update for '21B0R2RQ4TNT0'
2024-05-05 08:53:39.273 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Entities not added yet, fetch all for '21B0R2RQ4TNT0'
2024-05-05 08:53:40.497 DEBUG (MainThread) [homeassistant.components.synology_dsm.coordinator] Finished fetching 192.168.100.200 SynologyDSMCentralUpdateCoordinator data in 1.224 seconds (success: True)

with this change

2024-05-05 09:10:07.376 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] State of Surveillance_station during setup of '21B0R2RQ4TNT0': False
2024-05-05 09:10:07.476 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable security api updates for '21B0R2RQ4TNT0'
2024-05-05 09:10:07.476 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable photos api updates for '21B0R2RQ4TNT0'
2024-05-05 09:10:07.476 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable storage api updates for '21B0R2RQ4TNT0'
2024-05-05 09:10:07.476 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable upgrade api updates for '21B0R2RQ4TNT0'
2024-05-05 09:10:07.476 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable system api updates for '21B0R2RQ4TNT0'
2024-05-05 09:10:07.476 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Enable utilisation api updates for '21B0R2RQ4TNT0'
2024-05-05 09:10:07.476 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Start data update for '21B0R2RQ4TNT0'
2024-05-05 09:10:07.476 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Entities not added yet, fetch all for '21B0R2RQ4TNT0'

cc @bdraco

Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue: #116755
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] I have followed the perfect PR recommendations
[x] The code has been formatted using Ruff (ruff format homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

home-assistant[bot] commented 1 week ago

Hey there @hacf-fr, @quentame, mind taking a look at this pull request as it has been labeled with an integration (synology_dsm) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `synology_dsm` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign synology_dsm` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

bdraco commented 1 week ago

Looks right to me. Tagged since we are having timeout issues.

Will check on my production system shortly and approve if all is well

mib1185 commented 1 week ago

thanks for additional tests with using cameras 👍

home-assistant / core