Closed jbouwh closed 1 week ago
Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (file
) you are listed as a code owner for? Thanks!
Too much for a single PR I think.
Too much for a single PR I think.
Yeah, I know. I'll see if I can pop some parts out.
At least the change to config flow and the new NotifyEntity should be in different PRs but I didn't look too carefully so maybe there is something else too which can go into a preliminary PR
@gjohansson-ST I Have removed the implemention of the new entity platform. Disadvantage is that we cannot fase out the old service with the yaml clean up if the follow up PR is merged later. So now I need to use discovery to set up the legacy service from the entry data.
Will split up in 2 parts: 1: this PR to implement the config entry 2: a future PR to implement the new notify entity
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Thnx!
Follow up on late review: https://github.com/home-assistant/core/pull/117210
Breaking change
The notify services for the
file
integration now require that the file path is an allowed path. Users should check the accessed file is in the allowlist_external_dirs to ensure their automation's keep working.Proposed change
This PR will:
notify
services cannot access files if they are not added to the allowlist_external_dirs.This PR prepares for another PR to open soon:
notify
entity for everyfile
notify service.Screenshots
Final results after https://github.com/home-assistant/core/pull/117210 and https://github.com/home-assistant/core/pull/117215:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: