home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.03k stars 28.28k forks source link

Migrate slack dependency to slack-sdk #116868

Open tkdrob opened 1 week ago

tkdrob commented 1 week ago

Proposed change

Migrate slack to use the latest version available from Slack. The way we currently upload files via the notify service will break in March 2025. This PR comes before the actual fix for that. Blocking calls are currently being made within the dependency during file upload. So that will take some more work.

https://github.com/slackapi/python-slack-sdk/compare/2.5.0...v3.27.1

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 1 week ago

Hey there @fletcherau, mind taking a look at this pull request as it has been labeled with an integration (slack) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `slack` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign slack` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.