Migrate OpenWeaterMap to new library (support API 3.0)

freekode commented 1 week ago

Breaking change

Migration to new library with support of OneCall API (3.0)

Proposed change

Migrate new library pyopenweathermap I created specifically for Home Assistant. Currently, used pyowm library didn't have an update for a long time and seems dead. Remove forecast modes, one call allows to retrieve daily and hourly forecasts. Remove migration from V1 to V2 of config_flow, forecast mode isn't used anymore, there is no need for migration.

New lib https://github.com/freekode/pyopenweathermap

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[x] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #115714 fixes #113000
This PR is related to issue:
Link to documentation pull request: home-assistant/home-assistant.io#32609

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] I have followed the perfect PR recommendations
[x] The code has been formatted using Ruff (ruff format homeassistant tests)
[x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

[x] I have reviewed two other open pull requests in this repository.

home-assistant[bot] commented 1 week ago

Hey there @fabaff, @nzapponi, mind taking a look at this pull request as it has been labeled with an integration (openweathermap) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `openweathermap` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign openweathermap` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

bdraco commented 1 week ago

I was hoping to be able to do another review pass on this before I'm flying all day tomorrow but it looks like the day got away from me. I'll be traveling for a week so I'll minimal time to look at this one. I'd like to try to get it merged before the 2024.6.x beta though given API 2.5 is going to go away.

bdraco commented 6 days ago

Tested. Everything looks good.

Was able to switch from v2.5 to v3.0 and back.

bdraco commented 6 days ago

I'm still traveling until Thursday, but I wanted to give you feedback on the issue so we can be sure to get it in before beta.

freekode commented 6 days ago

I'm still traveling until Thursday, but I wanted to give you feedback on the issue so we can be sure to get it in before beta.

Thanks, have a nice trip :)

frenck commented 7 hours ago

I've marked this PR, as changes are requested that need to be processed. Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

home-assistant / core