home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.03k stars 28.28k forks source link

Handle command_line missing discovery_info #116873

Open yarikoptic opened 1 week ago

yarikoptic commented 1 week ago

Proposed change

Just make code more "correct" as signature allows for None but then code assumes that it is a DiscoveryInfoType. In this case also in case of an empty constract or none - just return with a warning (since I guess it is unexpected)

Type of change

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 1 week ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] commented 1 week ago

Hey there @gjohansson-st, mind taking a look at this pull request as it has been labeled with an integration (command_line) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `command_line` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign command_line` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.