Open yarikoptic opened 1 week ago
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Hey there @gjohansson-st, mind taking a look at this pull request as it has been labeled with an integration (command_line
) you are listed as a code owner for? Thanks!
Proposed change
Just make code more "correct" as signature allows for
None
but then code assumes that it is aDiscoveryInfoType
. In this case also in case of an empty constract or none - just return with a warning (since I guess it is unexpected)Type of change
[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests
This PR fixes or closes issue: fixes #116871
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: