Closed elupus closed 1 week ago
Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (integration
) you are listed as a code owner for? Thanks!
We might even want to remove the option of configuring rounding fully from config flow, and just have it control display precision for yaml config?
It's not just about display, it's a calculation that eventually gets exported to outside home assistant (e.g. influxDB)
Yes i know that.. and rounding is wrong for that too (in my opinion). Loosing precision. But it would be a semi breaking change there. So opted for making it optional instead.
Again it depends a lot on the use cases :)
Proposed change
Allow the rounding option be optional since we now support display precision to control the number of displayed digits of a value.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: