search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.55k stars 30.73k forks source link

No option to ignore a repair that cannot be completed anyway #116936

Closed alexruffell closed 6 months ago

alexruffell commented 6 months ago

The problem

I updated Unifi OS on my UNVR to an unsupported version and got a repair stating that "Authentication expired on UNVR". Given the 4.0.3 OS is not yet supported (please don't lecture me on this, I updated 100% knowing it was not supported and did not care) the "UniFi Protect Reauth" fails with "Invalid authentication" and leaves you with a repair you cannot perform, and cannot ignore until the support for the new OS is added to the integration.

image image image

Note: Since I've read some very touchy comments on users complaining about unsupported versions of Unifi software, let me repeat that this issue is NOT about that (plus I am NOT complaining, just trying to help), but the fact there is no option to ignore the repair which appears to be an oversight. I am guessing the issue is therefore with core and not the unifi protect integration. The screenshots above show all the places I looked for such an option, but found none.

What version of Home Assistant Core has the issue?

core-2024.5.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

joostlek commented 6 months ago

There is no option to hide a reauth flow

alexruffell commented 6 months ago

There is no option to hide a reauth flow

Are you saying it is intended? If so, it is confusing that it shows under "Repairs" as those can be ignored (as far as I've seen). To get around this, I disabled the integration and had to restart HA as I could not get the repair to go away otherwise. There has to be a better way of handling this :)

Calimerorulez commented 6 months ago

I had the same problem. I removed the integration and reinstalled it, but it keeps telling me that authentication has failed.

joostlek commented 6 months ago

This is intended. This is breaking the integration, and this will make sure people actually see why this is an issue. Otherwise you have people just click ignore and then question themselves why it doesn't work. But since this is a critical issue for the integration, it's persistent.

Having a broken lock at your home which prevents you from entering is also an issue you can't simply ignore.

alexruffell commented 6 months ago

This is intended. This is breaking the integration, and this will make sure people actually see why this is an issue. Otherwise you have people just click ignore and then question themselves why it doesn't work. But since this is a critical issue for the integration, it's persistent.

@joostlek Makes sense. From a usability perspective, it could have been implemented somewhat differently. For example, adding a note that this type of "repair" cannot be ignored because [fill in high level reason]. Your explanation makes total sense but the fact repairs always (or so I thought) have an ignore option, and this one didn't, sent me for a loop.

alexruffell commented 6 months ago

I had the same problem. I removed the integration and reinstalled it, but it keeps telling me that authentication has failed.

@Calimerorulez - Unifi OS 4.0.3 for the NVR is EA so it is not supported and in this case it breaks the integration. This issue is not about that, but rather how the reauth flow repair has no ignore option (which is correct and now makes sense). For the Unifi related issue, you should just disable the integration until an update comes out supporting it (given how awesome they are, it is likely a matter of days as it was for the UDMP not long ago).