home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.8k stars 28.94k forks source link

Missing sound mode DTS:X for Denon AVR integration #117255

Open cromefire opened 1 month ago

cromefire commented 1 month ago

The problem

The logger logs the following:

Logger: denonavr.soundmode
Source: components/denonavr/media_player.py:359
First occurred: May 10, 2024 at 21:49:39 (1 occurrences)
Last logged: May 10, 2024 at 21:49:39

Not able to match sound mode: 'DTS:X', assuming 'DTS SURROUND'.

What version of Home Assistant Core has the issue?

2024.5.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Denon AVR

Link to integration documentation on our website

https://www.home-assistant.io/integrations/denonavr/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: denonavr.soundmode
Source: components/denonavr/media_player.py:359
First occurred: May 10, 2024 at 21:49:39 (1 occurrences)
Last logged: May 10, 2024 at 21:49:39

Not able to match sound mode: 'DTS:X', assuming 'DTS SURROUND'.

Additional information

Similar to Atmos, DTS:X cannot just be activated on any content, but it will activate when DTS:X is being supplied by the source. Basically you should probably handle it like Atmos.

I have an AVC-X3800H, so it might be newer than what this integration was developed against.

home-assistant[bot] commented 1 month ago

Hey there @ol-iver, @starkillerog, mind taking a look at this issue as it has been labeled with an integration (denonavr) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `denonavr` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign denonavr` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


denonavr documentation denonavr source (message by IssueLinks)

cromefire commented 1 month ago

After looking at Atmos for a little bit it seems Atmos too isn't mapped currently, as it is being displayed as Dolby Digital and other sound modes on TrueHD don't seem to be mapped as well:

Logger: denonavr.soundmode
Source: components/denonavr/media_player.py:359
First occurred: 13:50:07 (4 occurrences)
Last logged: 13:50:48

Not able to match sound mode: 'DOLBY AUDIO-TRUEHD', assuming 'DOLBY DIGITAL'.
Not able to match sound mode: 'DOLBY AUDIO-TRUEHD+DSUR', assuming 'DOLBY DIGITAL'.
Not able to match sound mode: 'DOLBY AUDIO-TRUEHD+NEURAL:X', assuming 'DOLBY DIGITAL'.
Not able to match sound mode: 'AURO2DSURR', assuming 'AURO3D'.

If you can tell me where I can get the IDs, I can provide you with a list of human readable names and IDs that are possible.

jum0n commented 2 weeks ago

I'm getting one error in my logs that doesn't look like it should be in error. Guess an ID mismatch if that is something not visible here?:

Not able to match sound mode: 'AURO3D', assuming 'AURO3D'.

starkillerOG commented 2 weeks ago

I added the missing sound modes in this PR in the upstream library: https://github.com/ol-iver/denonavr/pull/296 thanks for reporting them!