Closed tr4nt0r closed 2 weeks ago
Hey there @asmfreak, @leikoilja, mind taking a look at this pull request as it has been labeled with an integration (habitica
) you are listed as a code owner for? Thanks!
Wouldn't it be better to fix this upstream?
Wouldn't it be better to fix this upstream?
The habitipy library itself is not natively async, it just has an abstraction layer, that allows the usage of aiohttp
instead of requests
, as backend. I think rewriting the library would be a lot harder, at least for me, as I'm still pretty new to python.
Proposed change
The Habitipy library loads the api definitions from a file during instantiation. This now happens in the executor.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: