home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.25k stars 28.47k forks source link

Support HmIP-BSL after firmware update to 2.0 #117657

Open hahn-th opened 2 weeks ago

hahn-th commented 2 weeks ago

Proposed change

Support for HmIP-BSL device with firmware > 2.0

Needs homematicip-rest-api version 1.1.1: https://github.com/hahn-th/homematicip-rest-api/blob/master/CHANGELOG.md

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 2 days ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

hahn-th commented 1 day ago

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

* A link to the release notes of this package version, and all versions in between.

* A link to the changelog of this package.

* A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

I added a description. I already bumped homematicip-rest-api to Version 1.1.1 with PR: https://github.com/home-assistant/core/pull/117175