home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.47k stars 28.66k forks source link

Add support for Glances v4 #117664

Closed wittypluck closed 3 weeks ago

wittypluck commented 1 month ago

Proposed change

This PR adds support for Glances v4. Glances v4 is the new default version in dockerhub since may 2024, so people updating their Glances docker instance to "latest" get an error in Home Assistant (unable to connect).

Glances v4 also introduces a change on network sensor naming, which needs to be handled in the underlying python-glances-api library: https://github.com/home-assistant-ecosystem/python-glances-api/pull/40

Consequently, this PR upgrades the library glances-api from version 0.6.0 to version 0.7.0. Changelog:

https://github.com/home-assistant-ecosystem/python-glances-api/releases/tag/0.7.0

No change in the support of previous versions of Glances.

Type of change

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

To help with the load of incoming pull requests:

home-assistant[bot] commented 1 month ago

Hey there @engrbm87, mind taking a look at this pull request as it has been labeled with an integration (glances) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `glances` can trigger bot actions by commenting: - `@home-assistant close` Closes the pull request. - `@home-assistant rename Awesome new title` Renames the pull request. - `@home-assistant reopen` Reopen the pull request. - `@home-assistant unassign glances` Removes the current integration label and assignees on the pull request, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
engrbm87 commented 4 weeks ago

I think CI is failing because the test_entry_deprecated_version assumes that only 2 versions are being tested. This needs to be updated as we are now testing 3 versions.

wittypluck commented 4 weeks ago

Good point, should be fixed now.

engrbm87 commented 4 weeks ago

LGTM

wittypluck commented 3 weeks ago

Thank you!