Improve Elmax alarm control panel - Githubissues

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.

https://www.home-assistant.io

Apache License 2.0

69.25k stars 28.47k forks source link

Improve Elmax alarm control panel #117689

Open albertogeniola opened 2 weeks ago

albertogeniola commented 2 weeks ago

Proposed change

Fixes #117650 and implements ARMING and DISARMING intermediate states.

Depends on: https://github.com/home-assistant/core/pull/117693

Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Deprecation (breaking change to happen in the future)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #117650
This PR is related to issue:
Link to documentation pull request:

Checklist

[x] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] I have followed the perfect PR recommendations
[x] The code has been formatted using Ruff (ruff format homeassistant tests)
[x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
[ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

[ ] I have reviewed two other open pull requests in this repository.

joostlek commented 2 weeks ago

Please bump the dependency in a preliminary PR

albertogeniola commented 2 weeks ago

Please bump the dependency in a preliminary PR

Done here: https://github.com/home-assistant/core/pull/117693

albertogeniola commented 1 week ago

Rebased after meeting dependent PR:#117693

home-assistant[bot] commented 1 week ago

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

fabioz23 commented 4 days ago

Hi all, any update on that PR?

Seems stale.