Changes in prioritisation of sentence matching in Assist have unwanted consequences

[jlpouffier]

The problem

The sentences to add items to a todo list in French are complex: https://github.com/home-assistant/intents/blob/main/sentences/fr/todo_HassListAddItem.yaml

This is because the article that a French speaker puts in front of the item to add (And before the add verb) depends on if the article is masculine, feminine, countable or not, plural or not.

So if a user wants to add

• Milk

• Flour

• Eggs To his shopping list, he will say

• Ajoute du lait a la liste des courses

• Ajoute de la farine a la liste des courses

• Ajoute des oeufs a la liste des courses

The sentences created long ago worked well in core-2024.5.5, as shown in this screenshot:

You can see the different articles being ignored, and the correct item being added to the list. (NOTE: I just rolled back to confirm this behavior)

Since 2024.6 (I am currently on core-2024.6.0b5, it is not the case anymore. The different articles are now matched with the item, as shown in this screenshot:

I think this is due to a change in how the literal chunks of text are prioritized in our matching logic.

@synesthesiam: Is this a problem in our logic? Or should we change our sentences?

Thx a lot

What version of Home Assistant Core has the issue?

core-2024.6.0b5

What was the last working version of Home Assistant Core?

core-2024.5.5

What type of installation are you running?

Home Assistant OS

Integration causing the issue

assist_pipeline

Link to integration documentation on our website

https://www.home-assistant.io/integrations/assist_pipeline/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

[home-assistant[bot]]

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this issue as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `conversation` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign conversation` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

---

conversation documentation conversation source _{^{(message by IssueLinks)}}

[home-assistant[bot]]

Hey there @balloob, @synesthesiam, mind taking a look at this issue as it has been labeled with an integration (assist_pipeline) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `assist_pipeline` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign assist_pipeline` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

---

assist_pipeline documentation assist_pipeline source _{^{(message by IssueLinks)}}

[synesthesiam]

This is surprising to me. Sentences with more literal text chunks matched are prioritized, so I would expect the text matched by the wildcard to be less. I will need to test this more and figure out what's happening.