home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.13k stars 29.8k forks source link

workday subdivision of country become number #119250

Closed lysiong closed 3 months ago

lysiong commented 3 months ago

The problem

subdivision of country is missing for Malaysia after update to 2024.6.1. It should list out all the state of Malaysia but now become numbers 01 to 16, if I based on KL, which number should I choose?

What version of Home Assistant Core has the issue?

2024.6.1

What was the last working version of Home Assistant Core?

2024.5.x

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Workday

Link to integration documentation on our website

https://www.home-assistant.io/integrations/workday

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 3 months ago

Hey there @fabaff, @gjohansson-st, mind taking a look at this issue as it has been labeled with an integration (workday) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `workday` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign workday` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


workday documentation workday source (message by IssueLinks)

lysiong commented 3 months ago

based on this link https://pypi.org/project/holidays/ it show that States and federal territories: 01 (Johor), 02 (Kedah), 03 (Kelantan), 04 (Melaka), 05 (Negeri Sembilan), 06 (Pahang), 07 (Pulau Pinang), 08 (Perak), 09 (Perlis), 10 (Selangor), 11 (Terengganu), 12 (Sabah), 13 (Sarawak), 14 (WP Kuala Lumpur), 15 (WP Labuan), 16 (WP Putrajaya)

it show that I should choose 14 if I based on Kuala Lumpur.