home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.79k stars 28.93k forks source link

Getting websocket_api LinkPlayDevice.async_join_players() got an unexpected keyword argument 'group_members' #119435

Open kyme32 opened 3 weeks ago

kyme32 commented 3 weeks ago

The problem

Hello,

When i try to join speakers with media_player.join service its errors out but if i use Linkplay service it works. Can be this fixed for media_player also, there are more custom components that uses media_player to join speakers Setup i have

Core 2024.6.2 Supervisor 2024.06.0 Operating System 12.3 Frontend 20240610.0

  Logger: homeassistant.components.websocket_api.http.connection
  Source: core.py:749
  integration: Home Assistant WebSocket API (documentation, issues)
  First occurred: 12:19:27 AM (1 occurrences)
  Last logged: 12:19:27 AM

  [139670286488128] Error handling message: Unknown error (unknown_error) xxx xxx from 82.xx.xx.xx (Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:126.0) Gecko/20100101 Firefox/126.0)
  Traceback (most recent call last):
    File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 27, in _handle_async_response
      await func(hass, connection, msg)
    File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 793, in handle_execute_script
      script_result = await script_obj.async_run(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 1769, in async_run
      return await asyncio.shield(create_eager_task(run.async_run()))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 464, in async_run
      await self._async_step(log_exceptions=False)
    File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 528, in _async_step
      self._handle_exception(
    File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 558, in _handle_exception
      raise exception
    File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 526, in _async_step
      await getattr(self, handler)()
    File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 763, in _async_call_service_step
      response_data = await self._async_run_long_action(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 726, in _async_run_long_action
      return await long_task
             ^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/core.py", line 2741, in async_call
      response_data = await coro
                      ^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/core.py", line 2784, in _execute_service
      return await target(service_call)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 977, in entity_service_call
      single_response = await _handle_entity_call(
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1041, in _handle_entity_call
      task = hass.async_run_hass_job(job)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/core.py", line 939, in async_run_hass_job
      return self._async_add_hass_job(hassjob, *args, background=background)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/core.py", line 749, in _async_add_hass_job
      hassjob.target(*args), name=hassjob.name, loop=self.loop
      ^^^^^^^^^^^^^^^^^^^^^
  TypeError: LinkPlayDevice.async_join_players() got an unexpected keyword argument 'group_members'

2nd error

  Logger: homeassistant.helpers.script.websocket_api_script
  Source: helpers/script.py:526
  First occurred: 12:19:27 AM (1 occurrences)
  Last logged: 12:19:27 AM

  websocket_api script: Error executing script. Unexpected error for call_service at pos 1: LinkPlayDevice.async_join_players() got an unexpected keyword argument 'group_members'
  Traceback (most recent call last):
    File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 526, in _async_step
      await getattr(self, handler)()
    File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 763, in _async_call_service_step
      response_data = await self._async_run_long_action(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 726, in _async_run_long_action
      return await long_task
             ^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/core.py", line 2741, in async_call
      response_data = await coro
                      ^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/core.py", line 2784, in _execute_service
      return await target(service_call)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 977, in entity_service_call
      single_response = await _handle_entity_call(
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 1041, in _handle_entity_call
      task = hass.async_run_hass_job(job)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/core.py", line 939, in async_run_hass_job
      return self._async_add_hass_job(hassjob, *args, background=background)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/src/homeassistant/homeassistant/core.py", line 749, in _async_add_hass_job
      hassjob.target(*args), name=hassjob.name, loop=self.loop
      ^^^^^^^^^^^^^^^^^^^^^
  TypeError: LinkPlayDevice.async_join_players() got an unexpected keyword argument 'group_members'

What version of Home Assistant Core has the issue?

2024.6.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Maxi Media Player/HACS

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 3 weeks ago

Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (websocket_api) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `websocket_api` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign websocket_api` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


websocket_api documentation websocket_api source (message by IssueLinks)