home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
74.07k stars 31.09k forks source link

ISS integration: regular connection issues (instable integration) #119972

Open bcutter opened 5 months ago

bcutter commented 5 months ago

The problem

ISS integration with regular unavailable sensor data roughly for 3 weeks (according to InfluxDB exactly since June 1st 07:38 CEST). Very instable integration.

What version of Home Assistant Core has the issue?

core-2023.4.6

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

iss

Link to integration documentation on our website

https://www.home-assistant.io/integrations/iss

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

#2 + #3 quite rarely, #1 is the core issue:

1)
Logger: homeassistant.components.iss
Source: helpers/update_coordinator.py:193
Integration: International Space Station (ISS) (documentation, issues)
First occurred: 15. Mai 2024 um 22:57:13 (5692 occurrences)
Last logged: 16:11:14

Error fetching iss data: Unable to retrieve data
Timeout fetching iss data

2)
Logger: homeassistant.components.iss
Source: components/iss/__init__.py:35
Integration: International Space Station (ISS) (documentation, issues)
First occurred: 11. Juni 2024 um 06:22:57 (512 occurrences)
Last logged: 14. Juni 2024 um 06:30:59

Unexpected error fetching iss data: Error server n 500
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 250, in _async_refresh
    self.data = await self._async_update_data()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 206, in _async_update_data
    return await self.update_method()
  File "/usr/src/homeassistant/homeassistant/components/iss/__init__.py", line 48, in async_update
    return await hass.async_add_executor_job(update, iss)
  File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/iss/__init__.py", line 35, in update
    number_of_people_in_space=iss.number_of_people_in_space(),
  File "/usr/local/lib/python3.10/site-packages/pyiss/__init__.py", line 101, in number_of_people_in_space
    return self.people_in_space()['number']
  File "/usr/local/lib/python3.10/site-packages/pyiss/__init__.py", line 31, in people_in_space
    raise Exception("Error server n {}".format(data.status_code))
Exception: Error server n 500

3)
Logger: homeassistant.components.iss
Source: components/iss/__init__.py:36
Integration: International Space Station (ISS) (documentation, issues)
First occurred: 11. Juni 2024 um 07:03:41 (22 occurrences)
Last logged: 14. Juni 2024 um 00:30:51

Unexpected error fetching iss data: Error server n 500
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 250, in _async_refresh
    self.data = await self._async_update_data()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 206, in _async_update_data
    return await self.update_method()
  File "/usr/src/homeassistant/homeassistant/components/iss/__init__.py", line 48, in async_update
    return await hass.async_add_executor_job(update, iss)
  File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/iss/__init__.py", line 36, in update
    current_location=iss.current_location(),
  File "/usr/local/lib/python3.10/site-packages/pyiss/__init__.py", line 45, in current_location
    raise Exception("Error server n {}".format(data.status_code))
Exception: Error server n 500

Additional information

grafik

home-assistant[bot] commented 5 months ago

Hey there @durgnomis-drol, mind taking a look at this issue as it has been labeled with an integration (iss) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `iss` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign iss` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


iss documentation iss source (message by IssueLinks)

philipp-frank commented 5 months ago

Same problem here.

AlphaNumericPencil commented 5 months ago

Same here. I got around the issue by caching the values I want from this integration into template sensors, and referencing those. Something should probably be added to the integration itself to do something similar if the connection issue with the endpoint can't be resolved.

philipp-frank commented 4 months ago

It looks like there is an open PR that could address this - https://github.com/HydrelioxGitHub/pyiss/pull/8.

bcutter commented 4 months ago

Hopefully there's some progress as this exists for weeks now. That intense of instability is not worthy of an official integration.

Otherwise unfortunately removal is an option for me, as currently instability > value added.

(edit / note for myself: I suppressed the alterting mechanisms in problematic entity notification template sensor as well as Watchman integration now @ 2024-07-28 16:40, now it's "just" the HA log still getting spammed.)

c3p0vsr2d2 commented 3 months ago

That intense of instability is not worthy of an official integration.

Grudgingly agree. I have a multiscrape sensor for ISS location/etc that I manually created which becomes unavailable much less frequently than this official integration. Looks like this issue has been stagnant for 2 months as well.

bcutter commented 4 weeks ago

So I think this will literally never get fixed. It's been roughly 5 months now, I consider that as an unfortunate proof of the previous sentence. I think I'm therefore going to ditch this integration. Too much bothering (triggering unavailable alerts and trashing the HA log *) for too little benefit.

Logger: homeassistant.components.iss
Quelle: helpers/update_coordinator.py:347
Integration: International Space Station (ISS) (Dokumentation, Probleme)
Erstmals aufgetreten: 1. Oktober 2024 um 18:50:40 (10583 Vorkommnisse)
Zuletzt protokolliert: 17:01:22

Error fetching iss data: Unable to retrieve data

(right, more than 10.000 events/lines - that was for last ~ 4 weeks only)