search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
74.19k stars 31.15k forks source link

Fitbit Component not working with Multiple trackers. #12032

Closed CCOSTAN closed 5 years ago

CCOSTAN commented 6 years ago

Home Assistant release (hass --version): 0.62

Component/platform: Fitbit

Description of problem: Looks like Fitbit is hardcoded to write it's configuration to fitbit.conf. Multiple trackers break this. Need to have an option for multiple conf files like light.

Expected: have multiple fitbits and different configuration files.

Additional info: https://community.home-assistant.io/t/fitbit-more-than-one-tracker/9666

BertrumUK commented 6 years ago

Is your current Fitbit still working ok since you updated to 0.62.0 ? If so what Python version are you running and what requests version are you on ?

See here

CCOSTAN commented 6 years ago

0.62. Broke my Skybell so I'm sitting tight on 0.61.1 right now via the 61.1 docker image. @BertrumUK

BertrumUK commented 6 years ago

@CCOSTAN OK. I am running Hassbian and there is a known issue affecting Fitbit and other OAuth devices with the current version of requests 2.18.4. rolling back to 2.14.2 did fix it but not any more.

CCOSTAN commented 6 years ago

Hey @robbiet480, Do I have to buy you a second Fitbit tracker? :)

point-4ward commented 6 years ago

@CCOSTAN - I've submitted a PR on your personal repo - have a look and let me know - if it works everyone else can test - cheers.

balloobbot commented 6 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:

CCOSTAN commented 6 years ago

This one is still pending. Fitbit does not work with multiple trackers.

tchellomello commented 6 years ago

I have this on my plate to extend this sensor too.

CCOSTAN commented 6 years ago

@tchellomello - This is the PR @mf-social referred to.. https://github.com/CCOSTAN/Home-AssistantConfig/pull/328 Maybe it can help with the development.

I'm available to test anything if that helps as well.

tchellomello commented 6 years ago

@CCOSTAN @mf-social it seems you guys already figured it out. Is there any reason why this PR has not yet been sent to the official repo?

CCOSTAN commented 6 years ago

@tchellomello - Not fully working. https://github.com/CCOSTAN/Home-AssistantConfig/issues/329 - Testing notes.

tchellomello commented 6 years ago

@CCOSTAN gotcha I'll take a look

balloobbot commented 6 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:

CCOSTAN commented 6 years ago

Still hoping for multiple user support on this.

cgarwood commented 5 years ago

Closing since not every component/platform supports multiple instances, so this is more of a feature request than a bug. Please post a thread in the feature requests section of the community forums.