home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.04k stars 30.17k forks source link

WLED integration shows error when device is offline #120919

Closed f-hicks closed 2 months ago

f-hicks commented 3 months ago

The problem

When a device is offline, it shows up as an error. This isn't helpful for device which are frequently turned off, so I believe it would be better to either show the device as "unavailable" as other integrations do, or allow the user to configure a setting to choose between these two options. For some devices, this is a very helpful notification, as it would prompt me to check the device, but for other devices it is not. For example, Christmas decorations I don't need to be told they are offline when they are not in use, just for them to be shown as unavailable in the background. image image

What version of Home Assistant Core has the issue?

core-2024.6.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

WLED

Link to integration documentation on our website

https://www.home-assistant.io/integrations/wled/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

This has been happening for quite a long time (not sure how long). It is likely expected behaviour, so would this be classed as a feature request?

Additional information

No response

home-assistant[bot] commented 3 months ago

Hey there @frenck, mind taking a look at this issue as it has been labeled with an integration (wled) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `wled` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign wled` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


wled documentation wled source (message by IssueLinks)

Phara0h commented 2 months ago

Happening to me too but when the devices are actually online and only half of them

frenck commented 2 months ago

When a device is offline, it shows up as an error. This isn't helpful for device which are frequently turned off, so I believe it would be better to either show the device as "unavailable" as other integrations do,

When the device the integration is connecting to is offline, it will show an error on the integration entry. The entities will be marked unavailable during that period (as you suggested, which is thus already the case).

For example, Christmas decorations I don't need to be told they are offline when they are not in use, just for them to be shown as unavailable in the background.

Home Assistant has an option to temporarily disable integration entries if you don't use them (three-dotted menu).

Reviewing the behavior based on the issue raised, the integration currently follows the correct behavior as documented and is supposed to do so according to HA standards.

../Frenck