search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
70.54k stars 29.47k forks source link

Withings log entries show incorrectly when no data found #121274

Open codyc1515 opened 1 month ago

codyc1515 commented 1 month ago

The problem

The log does not specify the correct entry (shows as %s instead).

What version of Home Assistant Core has the issue?

core-2024.7.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

withings

Link to integration documentation on our website

https://www.home-assistant.io/integrations/withings/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.components.withings
Source: components/withings/sensor.py:804
integration: Withings (documentation, issues)
First occurred: 15:04:46 (1 occurrences)
Last logged: 15:04:46

No data found for Withings entry %s, sensors will be added when new data is available

Additional information

No response

home-assistant[bot] commented 1 month ago

Hey there @joostlek, mind taking a look at this issue as it has been labeled with an integration (withings) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `withings` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign withings` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

withings documentation withings source (message by IssueLinks)

codyc1515 commented 1 month ago

This doesn't look right:

https://github.com/home-assistant/core/blob/62d9020261bb18fbbc40a5952448fe3854f1ba66/homeassistant/components/withings/sensor.py#L803-L806

joostlek commented 1 month ago

Oh lol, nice catch