home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
70.02k stars 29.09k forks source link

Generic Hygrostat config flow does not allow fan nor input_boolean entities to be selected as Switch #121566

Closed rrooggiieerr closed 1 week ago

rrooggiieerr commented 1 week ago

The problem

When creating a Generic Hygrostat helper using the new config flow I'm only able to select entities of the switch type. I can not select entities from the fan type nor the input_boolean type. When using the YAML configuration this is possible.

Only switch type entities can be selected:

Screenshot 2024-07-08 at 23 59 59

Using YAML this is allowed:

generic_hygrostat:
  - name: Bathroom Humidity
    humidifier: fan.bathroom
    target_sensor: sensor.bathroom_climate_humidity
    device_class: dehumidifier        
    min_cycle_duration:
        minutes: 5
    dry_tolerance: 3
    wet_tolerance: 3                          

What version of Home Assistant Core has the issue?

core-2024.7.1

What was the last working version of Home Assistant Core?

Never

What type of installation are you running?

Home Assistant OS

Integration causing the issue

generic_hygrostat

Link to integration documentation on our website

https://www.home-assistant.io/integrations/generic_hygrostat/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 week ago

Hey there @shulyaka, mind taking a look at this issue as it has been labeled with an integration (generic_hygrostat) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `generic_hygrostat` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign generic_hygrostat` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


generic_hygrostat documentation generic_hygrostat source (message by IssueLinks)

frenck commented 1 week ago

This is expected, see: https://github.com/home-assistant/core/pull/120989#issuecomment-2202964219

rrooggiieerr commented 1 week ago

@frenck Hmm, if it's now working in the YAML config to use a fan entity, and the documentation says it must ba a toggle device, which the fan entity is, then I think at least fan should be supported in the config flow

frenck commented 1 week ago

@rrooggiieerr Yes, that is considered a validation bug in YAML, as YAML will accept a sensor as an actuator even (any entity ID).

rrooggiieerr commented 1 week ago

A fan entity is not a sensor right? Its a device I can switch on to dehumidify my room, bathroom in my particular case