search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.38k stars 30.64k forks source link

SimpliSafe doesn't prompt for PIN to disarm, even though I've configured it to do so #121957

Open milnivlek opened 3 months ago

milnivlek commented 3 months ago

The problem

In the "Configure" options for the SimpliSafe option, I've set a PIN under the "Code (used in Home Assistant UI" field. This is supposed to require a PIN when disarming the system. However, it doesn't seem to have any effect. When I use the alarm control panel UI (under "more info") to select the "disarmed" state, it just goes ahead without prompting for a PIN.

This seems like a bug. The PIN is a valuable safeguard to ensure that the disarming can be done only by authorized users. Furthermore, it serves as a confirmation step to reduce the risk of a fat-fingered accidental disarm. Can someone please help take a look and prioritize fixing this?

Thanks a lot for all the great work!

What version of Home Assistant Core has the issue?

2024.7.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

SimpliSafe

Link to integration documentation on our website

https://www.home-assistant.io/integrations/simplisafe

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 3 months ago

Hey there @bachya, mind taking a look at this issue as it has been labeled with an integration (simplisafe) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `simplisafe` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign simplisafe` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

simplisafe documentation simplisafe source (message by IssueLinks)

bachya commented 3 months ago

PINs via the UI are outside the SimpliSafe integration's direct control, unfortunately. I'm not an expert in that system, but will leave this issue open—perhaps someone more versed in it can take a look.

veedubb65 commented 2 months ago

I don't know that I have much to add, but this affect my system as well. This did work previously, but I'm not sure what the last working version was.

I've tried changing the PIN to a different/longer number, and it has no effect. The PIN is ignored and never prompted. I've also tried this with both the default alarm panel card and the mushroom alarm panel card. Same behavior in both. It does make me think the issue is HA, and not specific to SimpliSafe.

patienttruth commented 2 months ago

It used to work, however mine isn't working either now.

I have a memory that this was noted as removed on a recent change log, but havent had the chance to research. It's still showing when I hit "configure" in the Simplisafe Integration.

patienttruth commented 2 months ago

Found it, this change happened in 2024.7, I don't fully understand why.

https://github.com/home-assistant/core/pull/118759