Automation And if (optional) using the wrong 'else'

fixx-er commented 1 month ago

The problem

Not sure if this goes into the core part, but when there is a condition in the "And if (optional)" part of an Automation and a person puts another IF under the proceding "THEN" and put an "ELSE", the "And if (optional)" uses that "ELSE". "And if (optional)" should not use an else at all. I have had to work aroound this by adding conditions after the "THEN"

Core 2024.7.2 Supervisor 2024.06.2 Operating System 12.4 Frontend 20240710.0

See snapshot: bad AND IF

What version of Home Assistant Core has the issue?

2024.7.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Automation

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

fixx-er commented 1 month ago

here are the last two traces I could find. It can be recreated if need be. trace automation.weather_for_cooler 2024-07-19T04_07_25.131565+00_00.json trace automation.weather_for_cooler 2024-07-19T06_08_21.660241+00_00.json

fixx-er commented 1 month ago

Old code:

`alias: Weather for cooler description: switch cooler modes when raining trigger:

platform: state entity_id:
- light.bath_sense_red for: hours: 0 minutes: 0 seconds: 0 condition:
condition: or conditions:
- condition: state entity_id: input_boolean.its_summer state: 'on'
- condition: state entity_id: input_boolean.season_manual state: 'on'
condition: state entity_id: switch.port_fan state: 'on' action:
variables: cooler_mode_on_current2: '{{ states(''input_text.cooler_mode_on_current'') }}' enabled: true
if:
- condition: state entity_id: light.bath_sense_red state: 'on' for: hours: 0 minutes: 0 seconds: 0 then:
- if:
  - condition: state entity_id: automation.cooler_in_rain state: 'off'
  - condition: not conditions:
  - condition: state entity_id: weather.home state: lightning-rainy
  - condition: state entity_id: weather.home state: lightning then:
  - service: input_text.set_value metadata: {} data: value: Hey Steve! - I am setting the cooling mode to rain - automation on because I hear it is raining. target: entity_id: input_text.ttssay
  - service: input_boolean.turn_off metadata: {} data: {} target: entity_id: input_boolean.empty_text
  - delay: hours: 0 minutes: 0 seconds: 1 milliseconds: 0
  - service: script.speak_and_resume metadata: {} data: {}
  - service: script.auto_off_cooler_normal data: {}
  - service: automation.turn_on metadata: {} data: {} target: entity_id: automation.cooler_in_rain else:
- condition: not conditions:
  - condition: state entity_id: weather.home state: lightning-rainy
  - condition: state entity_id: weather.home state: lightning
  - condition: state entity_id: weather.openweathermap state: lightning-rainy
  - condition: state entity_id: weather.openweathermap state: lightning
  - condition: state entity_id: weather.openweathermap state: pouring
  - condition: state entity_id: weather.openweathermap state: rainy
- if:
  - condition: or conditions:
  - condition: template value_template: '{{ states("input_text.cooler_mode_on_current") != "none" }}'
  - condition: template value_template: '{{ cooler_mode_on_current2 != "none" }}' then:
  - if:
  - condition: or conditions:
    - condition: template value_template: '{{ cooler_mode_on_current2 == "box_temp_adj_temp_high_81_cooler2" }}'
    - condition: template value_template: '{{ cooler_mode_on_current2 == "box_temp_adj_temp_high_81_cooler2" }}' then:
  - service: automation.turn_on metadata: {} data: {} target: entity_id:
    - automation.box_cooling_over_time_limit
    - automation.box_temp_adj_temp_high_81_cooler2 else:
  - service: automation.turn_on metadata: {} data: {} target: entity_id: automation.{{ cooler_mode_on_current2 }} enabled: false
- service: automation.turn_off metadata: {} data: stop_actions: true target: entity_id: automation.cooler_in_rain enabled: true
- if:
  - condition: or conditions:
  - condition: template value_template: '{{ states("input_text.cooler_mode_on_current") == "box_temp_adj_temp_high_81_cooler2" }}'
  - condition: template value_template: '{{ cooler_mode_on_current2 == "box_temp_adj_temp_high_81_cooler2" }}' then:
  - service: automation.turn_on metadata: {} data: {} target: entity_id:
    - automation.box_cooling_over_time_limit
    - automation.box_temp_adj_temp_high_81_cooler2 else:
  - service: automation.turn_on metadata: {} data: {} target: entity_id: automation.{{ cooler_mode_on_current2 }}
delay: hours: 0 minutes: 1 seconds: 0 milliseconds: 0 enabled: false mode: single`

New code:

`alias: Weather for cooler description: switch cooler modes when raining trigger:

platform: state entity_id:
- light.bath_sense_red for: hours: 0 minutes: 0 seconds: 0 condition: [] action:
condition: or conditions:
- condition: state entity_id: input_boolean.its_summer state: "on"
- condition: state entity_id: input_boolean.season_manual state: "on"
condition: state entity_id: switch.port_fan state: "on"
variables: cooler_mode_on_current2: "{{ states('input_text.cooler_mode_on_current') }}" enabled: false
if:
- condition: state entity_id: light.bath_sense_red state: "on" for: hours: 0 minutes: 0 seconds: 0 then:
- if:
  - condition: state entity_id: automation.cooler_in_rain state: "off"
  - condition: not conditions:
    - condition: state entity_id: weather.home state: lightning-rainy
    - condition: state entity_id: weather.home state: lightning then:
  - service: input_text.set_value metadata: {} data: value: >- Hey Steve! - I am setting the cooling mode to rain - automation on because I hear it is raining. target: entity_id: input_text.ttssay
  - service: input_text.set_value metadata: {} data: value: "{{ states('input_text.cooler_mode_on_current') }}" target: entity_id: input_text.cooler_mode_on_old
  - service: input_boolean.turn_off metadata: {} data: {} target: entity_id: input_boolean.empty_text
  - delay: hours: 0 minutes: 0 seconds: 1 milliseconds: 0
  - service: script.speak_and_resume metadata: {} data: {}
  - service: script.auto_off_cooler_normal data: {}
  - service: automation.turn_on metadata: {} data: {} target: entity_id: automation.cooler_in_rain
  - service: automation.turn_off metadata: {} data: stop_actions: true target: entity_id: automation.box_cooling_over_time_limit else:
- condition: not conditions:
  - condition: state entity_id: weather.home state: lightning-rainy
  - condition: state entity_id: weather.home state: lightning
  - condition: state entity_id: weather.openweathermap state: lightning-rainy
  - condition: state entity_id: weather.openweathermap state: lightning
  - condition: state entity_id: weather.openweathermap state: pouring
  - condition: state entity_id: weather.openweathermap state: rainy
- if:
  - condition: or conditions:
    - condition: template value_template: "{{ states(\"input_text.cooler_mode_on_current\") != \"none\" }}"
    - condition: template value_template: "{{ cooler_mode_on_current2 != \"none\" }}" then:
  - if:
    - condition: or conditions:
      - condition: template value_template: >- {{ cooler_mode_on_current2 == "box_temp_adj_temp_high_81_cooler2" }}
      - condition: template value_template: >- {{ cooler_mode_on_current2 == "box_temp_adj_temp_high_81_cooler2" }} then:
    - service: automation.turn_on metadata: {} data: {} target: entity_id:
      - automation.box_cooling_over_time_limit
      - automation.box_temp_adj_temp_high_81_cooler2 else:
    - service: automation.turn_on metadata: {} data: {} target: entity_id: automation.{{ cooler_mode_on_current2 }} enabled: false
- service: automation.turn_off metadata: {} data: stop_actions: true target: entity_id: automation.cooler_in_rain enabled: true
- if:
  - condition: or conditions:
    - condition: template value_template: >- {{ states("input_text.cooler_mode_on_old") == "box_temp_adj_temp_high_81_cooler2" }}
    - condition: template value_template: >- {{ cooler_mode_on_current2 == "box_temp_adj_temp_high_81_cooler2" }} then:
  - service: automation.turn_on metadata: {} data: {} target: entity_id:
    - automation.box_cooling_over_time_limit
    - automation.box_temp_adj_temp_high_81_cooler2 else:
  - service: automation.turn_on metadata: {} data: {} target: entity_id: automation.{{ states("input_text.cooler_mode_on_old") }}
delay: hours: 0 minutes: 1 seconds: 0 milliseconds: 0 enabled: true mode: single `

home-assistant[bot] commented 1 month ago

Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (automation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `automation` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign automation` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

automation documentation automation source _{^{(message by IssueLinks)}}

fixx-er commented 1 month ago

I have been quite busy, but after this week I will try and duplicate again. There has been many reboots and some updates. I want to retest again and document.

home-assistant / core