Error in compilation of webrtc-noise-gain

freekdk commented 4 months ago

The problem

When starting home-assistant for the first time apparently webrtc-noise-gain needs to be installed and quite a number of .cc files need to be compiled. One of these compilations reports an error and webrtc-noise-gain does not get installed?

gcc -fno-strict-overflow -Wsign-compare -DNDEBUG -mbranch-protection=standard -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -DOPENSSL_LO AD_CONF -fwrapv -fno-semantic-interposition -mbranch-protection=standard -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-pr otector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g -IVendor/ -mbranch-prot ection=standard -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tabl es -fstack-clash-protection -Werror=return-type -g -IVendor/ -fPIC -DVERSION_INFO=1.2.3 -I/tmp/pip-install-7gezh1jz/webrtc-noise-ga in_47f5fbc972504b27ba65ab3f7269d4ef/webrtc-audio-processing -I/tmp/pip-install-7gezh1jz/webrtc-noise-gain_47f5fbc972504b27ba65ab3f7 269d4ef/webrtc-audio-processing/webrtc-audio-processing-1 -I/tmp/pip-install-7gezh1jz/webrtc-noise-gain47f5fbc972504b27ba65ab3f726 9d4ef/webrtc-audio-processing/subprojects/abseil-cpp-20230125.1 -I/tmp/pip-build-env-hmwi5uq0/overlay/lib/python3.12/site-packages/ pybind11/include -I/home/hass/hassvenv/include -I/usr/include/python3.12 -c -std=c++17 /tmp/pip-install-7gezh1jz/webrtc-noise-gain 47f5fbc972504b27ba65ab3f7269d4ef/webrtc-audio-processing/webrtc-audio-processing-1/modules/audio_processing/agc2/adaptive_mode_leve l_estimator.cc -o build/temp.linux-aarch64-cpython-312/tmp/pip-install-7gezh1jz/webrtc-noise-gain_47f5fbc972504b27ba65ab3f7269d4ef/ webrtc-audio-processing/webrtc-audio-processing-1/modules/audio_processing/agc2/adaptive_mode_level_estimator.o -fvisibility=hidden -g0 -DWEBRTC_LIBRARY_IMPL -DWEBRTC_ENABLE_SYMBOL_EXPORT -DNDEBUG -DWEBRTC_APM_DEBUG_DUMP=0 -D_GNU_SOURCE -DWEBRTC_LINUX -DWEBRTC_T HREAD_RR -DWEBRTC_POSIX -DWEBRTC_ARCH_LITTLE_ENDIAN -DWEBRTC_ARCH_ARM64 -DWEBRTC_ARCH_ARM_FAMILY -DWEBRTC_ARCH_64_BITS -DWEBRTC_HAS _NEON /tmp/pip-install-7gezh1jz/webrtc-noise-gain_47f5fbc972504b27ba65ab3f7269d4ef/webrtc-audio-processing/webrtc-audio-processing- 1/modules/audio_processing/agc2/adaptive_mode_level_estimator.cc: In function ‘float webrtc::{anoniem}::GetLevel(const webrtc::VadL evelAnalyzer::Result&, LevelEstimatorType)’: /tmp/pip-install-7gezh1jz/webrtc-noise-gain_47f5fbc972504b27ba65ab3f7269d4ef/webrtc-audio-processing/webrtc-audio-processing- 1/modules/audio_processing/agc2/adaptive_mode_level_estimator.cc:45:1: error: control reaches end of non-void function [-Werror=return-type] 45 | } | ^ cc1plus: some warnings are treated as errors

What version of Home Assistant Core has the issue?

core-2024.7.3

What was the last working version of Home Assistant Core?

core-2024.7.3

What type of installation are you running?

Home Assistant Core

Integration causing the issue

First startup of the system

Link to integration documentation on our website

No response

Diagnostics information

home-assistant.log

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

I installed a fresh openSUSE Tumbleweed on a Raspberry Pi 4B (4GB). Installed the necessary packages, created a user hass and started a venv in that user. Used pip to install wheel and homeassistant. Started home-assistant using systemd with the following hoe-assistannt.service file:

[Unit]
Description=Home Assistant
After=network.target mysql.service mariadb.service

[Service]
Type=simple
User=hass
#ExecStartPre=source /home/hass/hassvenv/bin/activate
ExecStart=/home/hass/hassvenv/bin/hass
SendSIGKILL=no
RestartForceExitStatus=100
# avoid hass amok runs
MemoryHigh=1024M
MemoryMax=2048M

[Install]
WantedBy=multi-user.target

During the first run I got this log with the error. It is apparently not fatal because I have a functioning Home Assistant server.

home-assistant[bot] commented 4 months ago

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this issue as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `conversation` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign conversation` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

conversation documentation conversation source _{^{(message by IssueLinks)}}

issue-triage-workflows[bot] commented 1 month ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

synesthesiam commented 1 month ago

webrtc-noise-gain has been replaced by pyspeex-noise

home-assistant / core