home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.76k stars 30.86k forks source link

Overkiz: AtlanticPassAPCHeatPumpMainComponent is not working correctly on dev #122976

Closed nyroDev closed 3 months ago

nyroDev commented 3 months ago

The problem

Following #122175, I tested on dev locally to be sure nothing was done on my setup.
I'm sorry I didn't test it before merge...

I do have the same component than mentionned by @alexfp14, but controller with a Somfy Tahoma, and not a cozytouch. So far, that's the only change I see.

Here is my setup on dev : config_entry-overkiz-f8b5ab9f89ad2f3d68af1817d43064f7 (1).json

When trying to see the water heat pump, here is what I see on dev:
Capture d’écran de 2024-07-31 22-35-15

Temperature is not editable.
And when I Change the mode, the water pump is not updated, but My 2 heating zone are set on.

On master, it's currently working correctly.
Here is my diagnostic file on master: config_entry-overkiz-9c69454e7c79a79866c4af647396c637 (1).json

And a screenshot:
Capture d’écran de 2024-07-31 22-39-39

Everything is working correctly, I'm using for 2 years now without any problem.

Please note that a WIDGET_AND_CONTROLLABLE_TO_CLIMATE_ENTITY was recently added to differenciate against controllable name and not only widtget name.

I gues the changes introduced in #114178 are also lost with the #122175

If I understand correctly what @alexfp14 did, we should probably introduce a difference based on the pod too...

What version of Home Assistant Core has the issue?

core-2024.8.0.dev0

What was the last working version of Home Assistant Core?

core-2024.7.4

What type of installation are you running?

Home Assistant Container

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 3 months ago

Hey there @imicknl, @vlebourl, @tetienne, @tronix117, @alexfp14, mind taking a look at this issue as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `overkiz` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign overkiz` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


overkiz documentation overkiz source (message by IssueLinks)

iMicknl commented 3 months ago

@nyroDev thanks for reporting! From your dev experience, what is breaking here? Does your device share the same UIWidget/UIClass?

alexfp14 commented 3 months ago

Hi @nyroDev. I think we are talking about different components.

If I understood well, you are talking about Atlantic Water Heater (which changes were done in https://github.com/home-assistant/core/pull/114178)

With the new PR (https://github.com/home-assistant/core/pull/122175) what has been introduced is a new feature to control the heat pump main component. This component doesn't have the capacity to adjust temperature, it can only be turned on (heating/cooling) or turned off. The temperatures settings must be made individually for each of the zones: IMG_6506 IMG_6505

nyroDev commented 3 months ago

@alexfp14 How dumb am I... My dev configuration was messed up and my dashboard on it was not what I was expecting.

I tested again and everything is working fine, as you mentionned you actually added a new component and not replacing an other one as I thought.

Thanks for your great work, and sorry for my bad testing and wrong bug reports.