search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.09k stars 29.75k forks source link

Withings reauth - wrong login credentials dismisses reauth repair item #123011

Open SeanPM5 opened 1 month ago

SeanPM5 commented 1 month ago

The problem

Continuation from https://github.com/home-assistant/core/issues/122999

I had to reauthorize two Withings accounts (mine and a family member), but I accidentally entered my email address instead of hers.

The reauth dialog said "wrong_account" which was helpful to let me know account credentials were wrong. But after clicking the "OK" button on that dialog, it removed the repair item, so there was no way to then enter the correct credentials. I had to reload the config entry for it to create another repair item / reauth flow, which most people wouldn't know to do.

IMO it shouldn't remove the repair item under this type of scenario (wrong account / failed login), only after successful reauth.

What version of Home Assistant Core has the issue?

2024.7.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Withings

Link to integration documentation on our website

https://www.home-assistant.io/integrations/withings/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 month ago

Hey there @joostlek, mind taking a look at this issue as it has been labeled with an integration (withings) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `withings` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign withings` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

withings documentation withings source (message by IssueLinks)

joostlek commented 1 month ago

Wait it only said wrong_account?

SeanPM5 commented 1 month ago

Yeah I'm like 90% sure it only said wrong_account as the message/content part of the dialog and nothing else. I don't remember if that dialog had a title or not.

joostlek commented 1 month ago

Oh that's something I have to fix.

For the rest, it should reload the integration after a wrong account, causing it to retrigger reauthentucating. The flow that initially was started is now over at this point, and a new one should be started