Linkplay Integration fails to setup

sspaul1976 commented 1 month ago

The problem

Testing the new Linkplay integration, and it will not autodiscover nor manually setup. I was previously using the custom component version which worked. Device is a Wiim Mini.

Screenshot_20240802-175146

What version of Home Assistant Core has the issue?

core-2024.8.0b1

What was the last working version of Home Assistant Core?

core-2024.8.0b1

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Linkplay

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 month ago

Hey there @velleman, mind taking a look at this issue as it has been labeled with an integration (linkplay) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `linkplay` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign linkplay` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

linkplay documentation linkplay source _{^{(message by IssueLinks)}}

dukeofphilberg commented 1 month ago

Hi, thanks for trying the integration. I can think of two things;

The Wiim Mini requires a https connection to send the commands, the python library currently does not support this
There's a timeout while trying to contact the Wiim Mini. Does it take 10s to try and add it?

sspaul1976 commented 1 month ago

Thank you for the reply. I do not see the integration setup elapsing 10 seconds before returning the error. It is nearly instantaneous.

On Mon, Aug 5, 2024, 02:40 Philip Vanloo @.***> wrote:

Hi, thanks for trying the integration. I can think of two things;

The Wiim Mini requires a https connection to send the commands, the python library currently does not support this

There's a timeout while trying to contact the Wiim Mini. Does it take 10s to try and add it?

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/123088#issuecomment-2268289884, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPFFBWZYCZ6SRG4X6NAWX3ZP4M5TAVCNFSM6AAAAABL5IOIIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYGI4DSOBYGQ . You are receiving this because you authored the thread.Message ID: @.***>

bencoldham commented 1 month ago

I'm getting the same error. Wiim Pro, instantaneous error, connected via ethernet on core-2024.8.0b2

DarrellVS commented 1 month ago

Backing this, having the exact same issue with my WiiM Pro and WiiM mini. Devices are not discovered through auto discovery, and an immediate "Failed to connect" appears when entering the device's IP addresses manually.

vsaintloup commented 1 month ago

Same here, tried all the 5 WiiM mini I have, immediate Failed to connect. (were all working with HACS "home-assistant-custom-components-wiim")

kellcomnet2 commented 1 month ago

Another wiim user here unable to add integration

velodromen commented 1 month ago

Same situation here with 6 Wiim Audio Pro. No auto discovery and the same experience with immediate Failed to connect.

All units are located on a separated VLAN from HA server, e.g. VLAN #1 for the units and VLAN #2 for HA server.

HA server on HTTPS. I too have previously succesfully connected to the units from HA using forementioned home-assistant-custom-components-wiim.

nhadler commented 1 month ago

Also having the same issue with my Wiim Pro

infamy commented 1 month ago

Can add another for issues with the wiim pro. I noticed the library does have a link to the Wiim api spec and can confirm that works with my unit but only over https.

Looking at the library it looks like it supports https, https://github.com/Velleman/python-linkplay/blob/68b43c5892d1c54a61510883ef933b9d74af4a83/src/linkplay/bridge.py#L223C1-L224C33

But the component for HASS does not allow setting the protocol (so its stuck at the default http) and the wiim devices need https.

And option to allow setting that would most likely allow this to be resolved if not ideal, (zeroconf still does not work) but it would make it usable for now.

Issue root is in the library https://github.com/Velleman/python-linkplay/blob/68b43c5892d1c54a61510883ef933b9d74af4a83/src/linkplay/discovery.py#L17 using the discovery bridge hardcodes us to http. Preventing the connection, that code could be reimplemented in the component or fixed in the library...

Have a proposed fix to the linkplay library which would be half the fix. https://github.com/Velleman/python-linkplay/issues/19

dukeofphilberg commented 1 month ago

Just want to give a status update; we're adding https support in the underlying library to fix this 😄

infamy commented 1 month ago

The merge request to track for this is -> https://github.com/Velleman/python-linkplay/pull/16 just so we can stay on top of it. From the looks of it, a change to the actual component will also be required beyond just updating the required library version.

horztisgreat34 commented 1 month ago

Same here with WiiM AMP

bakovari commented 3 weeks ago

Hey there, Was there any permanent solution? I've just tried the integration for wiim pro plus but the same immediate 'failed to connect' error occured. Core: 2024.8.2 Supervisor: 2024.8.0

Did I miss something?

Can anyone advise how to progress? Thanks for your help!

Cadabena commented 3 weeks ago

Hey there, Was there any permanent solution? I've just tried the integration for wiim pro plus but the same immediate 'failed to connect' error occured. Core: 2024.8.2 Supervisor: 2024.8.0

Did I miss something?

Can anyone advise how to progress? Thanks for your help!

A pull request fixing this was posted a few hours prior to your message, so I imagine we can look forward to seeing it very soon in a HA core update :)

SeRG1k17 commented 2 weeks ago

The same issue Rakoit m50 (arylic chip based) previous LinkPlay integration works correctly with this setup:

- platform: linkplay
  host: 192.168.1.11
  name: SoundSystem living room
  sources: { "airplay": "Airplay", "line-in": "Line-in" }
  uuid: FF97...

I yesterday updated all HA modules to latest

txitxo0 commented 1 week ago

Same in an Arylic H50

sspaul1976 commented 1 week ago

What version will this be implemented? Just tried in Core 2024.9.0b3 and seeing the same issue.

On Tue, Sep 3, 2024, 07:35 Joost Lekkerkerker @.***> wrote:

Closed #123088 https://github.com/home-assistant/core/issues/123088 as completed via #124307 https://github.com/home-assistant/core/pull/124307 .

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/123088#event-14113758690, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPFFBXNHBXN2LY7NORHXYTZUWNG7AVCNFSM6AAAAABL5IOIIGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGEYTGNZVHA3DSMA . You are receiving this because you authored the thread.Message ID: @.***>

home-assistant / core