Persistent Tado repair

[tjorim]

The problem

I was checking any repairs I had left (or ignored in the past) while on the August beta release of HA. I noticed there was still an old repair warning from Tado (not beta related):

Tado Water Heater entities now support fallback options Due to added support for water heaters entities, these entities may use different overlay. Please configure integration entity and tado app water heater zone overlay options. Warning - 16/6/2024 Ignore

I can ignore it but nothing else, it's not clear to me what to do. I already configured the integration again but the repair stays present. Seems to be related to https://github.com/home-assistant/core/pull/119526.

What version of Home Assistant Core has the issue?

core-2024.8.0

What was the last working version of Home Assistant Core?

core-2024.5.0

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Tado

Link to integration documentation on our website

https://www.home-assistant.io/integrations/tado

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

[home-assistant[bot]]

Hey there @chiefdragon, @erwindouna, mind taking a look at this issue as it has been labeled with an integration (tado) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `tado` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign tado` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

---

tado documentation tado source _{^{(message by IssueLinks)}}

[erwindouna]

@ethemcemozkan can you share your feedback on this issue?

[ethemcemozkan]

@erwindouna we can try to make the message clear. But for that I am open to suggestions. The message is: if users must check their Tado water heater zone overlay configurations and HA tado integration wide overlay fallback settings if they experience behavioral change for the water heater entity

On the other hand we had this repair issue for more than 2 versions, we can also remove it as well.

[erwindouna]

@erwindouna we can try to make the message clear. But for that I am open to suggestions. The message is: if users must check their Tado water heater zone overlay configurations and HA tado integration wide overlay fallback settings if they experience behavioral change for the water heater entity

On the other hand we had this repair issue for more than 2 versions, we can also remove it as well.

Is it something people still can encounter? Else, maybe we can provide feedback on how to solve it in this issue.

[tjorim]

Can we not declare the repair is_fixable by triggering the configure flow of the integration again? If user submits it there, they should be aware of the options and their app settings.

[ethemcemozkan]

@tjorim I think is_fixable is for programmatically fixable issue, this issue requires manual action as well as it is mostly informational hence the false value. If you don't see a problem with the way your waterheater entity works you can safely ignore this and it should not be visible again

@erwindouna this repair issue is created because previous bug was considered as the normal behavior and we received tickets about it. As a response we created this issue to inform users about the change and actions they must take in the tado app. The issue is only valid if user updates from an older version without my changes. If we have a statistics about active HA versions we can make a good decision.

[tjorim]

To me this does not sound like an actual issue that should warrant a repair (as long as it's working like documented). If the behaviour changed it should just be in the HA release post (in my opinion).

Anyway: "Issues can either be fixable via a RepairsFlow or by linking to a website with information on how the user can solve it themselves." and "If an issue has the is_fixable issue set to True, the user will be allowed to fix the issue.".

If the user reads the documentation (it currently doesn't link anywhere which resulted in my initial confusion) and checks the settings they should be allowed to mark it as fixed?

[erwindouna]

I agree to that. I will create a PR to mitigate this behaviour.