home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.84k stars 30.51k forks source link

KNX entity edit not available on mobile #123262

Closed massamino closed 2 months ago

massamino commented 2 months ago

The problem

The tabs on top in the knx view are not showing up. If desktop version is selected in chrome, they show up.

What version of Home Assistant Core has the issue?

2024.08 b5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 2 months ago

Hey there @julius2342, @farmio, @marvin-w, mind taking a look at this issue as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `knx` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign knx` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


knx documentation knx source (message by IssueLinks)

farmio commented 2 months ago

The tabs on narrow view are at the bottom. In entity-edit mode they are not visible - use "back" or "save" to close this view.

massamino commented 2 months ago

Screenshot_20240807-083025~2 Hello, thank you for the reply.. I know that it moves to tabs at the bottom, but in chrome they are not coming up. I can test it in the mobile app later.

farmio commented 2 months ago

Hm... it works fine on desktop-Chromes device-view dev tool 🙃 I haven't tested it on actual mobile devices, but since it uses standard HA webcomponents, I figured it should work fine 😬

DirkMu commented 2 months ago

Tested it on iPhone 13Pro with Chrome. Editing an entity is not possible since the project tree takes the majority of the page in portrait view.

image

farmio commented 2 months ago

Oops... 🙃 @DirkMu Since you are using that on an actual phone... does drag and drop work there (if you rotate it landscape)?

DirkMu commented 2 months ago

Yes, it works. A little bit clunky, I would say. I would rather hide the tree on specific viewport.

There is also unused space on the right image

massamino commented 2 months ago

Hm... it works fine on desktop-Chromes device-view dev tool 🙃 I haven't tested it on actual mobile devices, but since it uses standard HA webcomponents, I figured it should work fine 😬

FYI, the menu items are visible when in landscape (on top in this case)

massamino commented 2 months ago

I can see them now. Or it is fixed or my browser was having issues 😕. I will have to add it to the app as secondary server.

I try different pages and I can see the scrolling is different than on other pages. I think that's the reason why the browser flips. In the knx window the child container scrolls and on other pages it is the complete page I think. With the viewport size to 100vh, it has a gap and it won't make the address bar scroll out of sight by default. A second swipe does make it disappear. I hope this helps.

farmio commented 2 months ago

Not sure why this is like that... maybe because the Knx panel runs in an iFrame.

Maybe one day an actual frontend developer comes along and fixes all the hacks I made there 🤣

massamino commented 2 months ago

Well, good enough for me for now 😁. You can close the issue. Thank you for all the hard work on the knx integration. It has improved a lot. I'll be playing around some with the new settings available.

Kolbi commented 2 months ago

@farmio maybe we get the possibility to hide the right side? Then everything is fine use drag & drop if you want (and have the screen width) and otherwise use the manual way - but to be honest who does it on a mobilephone?

massamino commented 2 months ago

I would not use drag and drip on a phone. But I could tinker around and add an entity that way. 😎 I would for portrait screen just put the list on the bottom than you could still look at them.

farmio commented 2 months ago

https://github.com/home-assistant/core/issues/123262#issuecomment-2273889003 no idea where this empty space comes from. It doesn't appear on desktop browsers responsive view, but I have it in the HA app on mobile too 😬 Well, it can be used for iphone-notch-parking so not that bad after all 😛

massamino commented 2 months ago

It is not in the app on android, so that is good for me 😁