home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
74.18k stars 31.15k forks source link

HUE -Friends of HUE- button press event_type broke with 2024.7.4 #123282

Closed Asom-Velz closed 3 months ago

Asom-Velz commented 3 months ago

The problem

After updating to Home Assistant Core 2024.7.4 from 2024.7.3 all Friends of HUE switches stop reporting the button press event_type So the button - event_types: initial_press, repeat, short_release, long_press, long_release are not reporting anymore. Every automation which was triggered from a press event_type stopped working. When I revert to backup with Home Assistant Core 2024.7.3 everything is working fine. (tested twice)

What version of Home Assistant Core has the issue?

core-2024.7.4

What was the last working version of Home Assistant Core?

core-2024.7.3

What type of installation are you running?

Home Assistant OS

Integration causing the issue

HUE

Link to integration documentation on our website

https://www.home-assistant.io/integrations/hue

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 3 months ago

Hey there @balloob, @marcelveldt, mind taking a look at this issue as it has been labeled with an integration (hue) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `hue` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign hue` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


hue documentation hue source (message by IssueLinks)

marcelveldt commented 3 months ago

Is it only broken for FoH remotes or are regular remotes also affected?

Asom-Velz commented 3 months ago

I have FoH Vimar Switches with 4 Buttons total 12 devices https://www.vimar.com/en/int/catalog/product/index/code/03906 each button returns the following event_types: initial_press, repeat, short_release, long_press, long_release for the last 3 yrs without any problem till Core 2024.7.3
After updating to core- 2024.7.4 are not reporting anymore.

I don't have Philips HUE Dimmer set with automation's in order to know if there are affected too

rpzxc commented 3 months ago

@marcelveldt Regular Philips dimmers are unaffected - only the FoH. Over 20 Niko switches here, same issue.

it is probably the same issue as here: https://github.com/home-assistant/core/issues/119807

Asom-Velz commented 3 months ago

@marcelveldt Hi! I confirm that the FoH switches problem is still valid with 2024.8.0 - just tested and revert back to 2024.7.3

idekker commented 3 months ago

I think I found the root cause. Next to a fix I created for https://github.com/home-assistant-libs/aiohue/pull/377 the aiohue version 4.7.2 intake also contained another change to move from the deprecated last_event field to button_report.event, while aiohue is injecting events that are still using the last_event field.

I'll prepare a PR to change aiohue according and will try to find other places where last_event is still used, but I can only test with Hue Tap and Hue Dimmer Switch.

Asom-Velz commented 3 months ago

@idekker Hi any progress on the aiohue?

idekker commented 3 months ago

@Asom-Velz Created a PR with a fix (https://github.com/home-assistant-libs/aiohue/pull/388) and tested in on a borrowed FoH switch. Waiting for a code owner to review and merge

Asom-Velz commented 3 months ago

@idekker Thank you 🙂

Superkikim commented 3 months ago

Hi. I confrim I have the same issue with Feller Hue switches, including HA 2024.8.1 and 2024.8.2.

Anything I can do to help ?

idekker commented 3 months ago

The fix for aiohue is merged, but still needs to be integrated in HA core I think.

Asom-Velz commented 3 months ago

@idekker

Ok Thank you for the info 👌

Asom-Velz commented 3 months ago

@idekker Today I have updated to core 2024.8.3 and the FoH switches are working ok!!

I would like to thank you once again 😊😊