home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.72k stars 30.84k forks source link

HomeKit Bridge showing hidden entities in entity selection drop down #123317

Open clintebbesen opened 3 months ago

clintebbesen commented 3 months ago

The problem

After clicking on configure, when selecting entities to include, the list contains devices which are hidden in home assistant, such as changing a switch type from switch to Light, hides the switch and creates a light helper, both entities then show in the list, whereas only the light should be shown, not the switch which is hidden.

This issue, along with the design of the UI is making it extremely difficult to configure and find devices. I have hundreds of entities in the list, there is no search, no list of selected entities, no alphanumerical order (im sure there is but the list isnt in order, I have devices with similar names that are well apart in the list) etc.

It would also make it much easier and make this less of an issue if the UI was different, such as one idea is two lists, one list of entities not selected, and one of entities that are selected, or even just a second list of only selected devices so I can check over and see if I have added everything, currently I have to scroll a list of hundreds to try and check, but when im trying to check for 50 devices and there is no order, its hard / near impossible to see if I have missed something.

Ideally a different method for adding devices would be good, such as on the device itself, rather than in the current entities list. this would make it easy when adding a new device to tick something on the device itself to add it to HomeKit.

What version of Home Assistant Core has the issue?

core-2024.8.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

HomeKit Bridge

Link to integration documentation on our website

https://www.home-assistant.io/integrations/homekit

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 3 months ago

Hey there @bdraco, mind taking a look at this issue as it has been labeled with an integration (homekit) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `homekit` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign homekit` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


homekit documentation homekit source (message by IssueLinks)

andyblac commented 3 months ago

I agree, but IMO the HIDDEN should mean hidden, and not just hidden from a new overview dashboard. I.e if an entity is marked as hidden, it should ONLY show in the device page, and NO WHERE ELSE in Home Assistant, this would solve a lot of other issues as well.

maybe it would be easier to make any hidden entity ie switch.test should be changed to hidden.test or switch.test.hidden

clintebbesen commented 1 month ago

Hi @bdraco, I just noticed the Ui has changed, and I think its a step in the right direction, particularly how when one entity is added, when you go to add another any previous entities will be not visible in the list.

However the list is still extremely long, if its not too hard, I have a suggestion on how to greatly improve the experience.

Rather than selecting from all entities how it currently is, instead it could cycle through the user selected domains, only showing entities from one domain at a time. This would greatly improve the experience of selecting which entities are to be included. Eg first screen would show which light entities to select, then which fan entities, which scripts etc. When it comes to fans, the list is small, lights list is a decent size, etc but rather than picking from a list of 300 items, each list might only be 5-50 for my use case, and probably similar for a lot of other people.

thank you! Appreciate your help!

image

IMNotMax commented 2 weeks ago

The UI changed and not sure it's on the right direction... Previously, we had a check list ordered by domains. Quite good to select multiple entities to include or exclude. What a pain now :(