home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.14k stars 29.82k forks source link

TP-Link Smart Home keeps seeking firmware update when firmware entity is disabled #123417

Closed GoodnessJSON closed 2 weeks ago

GoodnessJSON commented 1 month ago

The problem

I have an issue where the TP-Link Smart Home integration keeps requesting firmware versions even when the firmware and update entities disabled.

I have all my TP-Link internet blocked with the firmware updates disabled, and I keep getting these logs being spammed in my system log:

Logger: kasa.smart.smartdevice
Source: components/tplink/coordinator.py:49
First occurred: 11:10:00 AM (10 occurrences)
Last logged: 11:50:00 AM

Error processing Firmware for device 192.168.1.81, module will be unavailable: get_latest_fw for Firmware (error_code=CLOUD_FAILED_ERROR)
Error processing Firmware for device 192.168.1.62, module will be unavailable: get_latest_fw for Firmware (error_code=CLOUD_FAILED_ERROR)

What version of Home Assistant Core has the issue?

core-2024.8.0

What was the last working version of Home Assistant Core?

core-2024.8.0

What type of installation are you running?

Home Assistant OS

Integration causing the issue

TP-Link Smart Home

Link to integration documentation on our website

https://www.home-assistant.io/integrations/tplink/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: kasa.smart.smartdevice
Source: components/tplink/coordinator.py:49
First occurred: 11:10:00 AM (10 occurrences)
Last logged: 11:50:00 AM

Error processing Firmware for device 192.168.1.81, module will be unavailable: get_latest_fw for Firmware (error_code=CLOUD_FAILED_ERROR)
Error processing Firmware for device 192.168.1.62, module will be unavailable: get_latest_fw for Firmware (error_code=CLOUD_FAILED_ERROR)

Additional information

It would be great if the get_latest_fw could be tied to the firmware update entity being active.

home-assistant[bot] commented 1 month ago

Hey there @rytilahti, @bdraco, @sdb9696, mind taking a look at this issue as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `tplink` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign tplink` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


tplink documentation tplink source (message by IssueLinks)

sdb9696 commented 2 weeks ago

@GoodnessJSON this will be fixed in the next beta release. It would be great if you could test this out.

GoodnessJSON commented 2 weeks ago

@GoodnessJSON this will be fixed in the next beta release. It would be great if you could test this out.

Will do! Thanks so much for the great fix. Appreciate it.