home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.9k stars 30.12k forks source link

homeassistant/components/pi_hole #123804

Closed garrathbond closed 1 month ago

garrathbond commented 1 month ago

The problem

do the update sensors work in pi hole as i cant get them to work on my setup (all 3)

What version of Home Assistant Core has the issue?

core-2024.8.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

pihole

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

image

home-assistant[bot] commented 1 month ago

Hey there @shenxn, mind taking a look at this issue as it has been labeled with an integration (pi_hole) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `pi_hole` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign pi_hole` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


pi_hole documentation pi_hole source (message by IssueLinks)

mib1185 commented 1 month ago

do you mean the sendor.xxx or the update.xxx entities?

garrathbond commented 1 month ago

image

garrathbond commented 1 month ago

image

mib1185 commented 1 month ago

please show a screenshot of the entity details - should look like:

image

and provide the full state details from developer tools states tab - should look like

image

abeltman commented 1 month ago

Same problem here after updating to 2024.8.1. All 3 Pi-Hole Update Sensor shows Update Available whilst Pi-Hole is fully up to date

image image
mib1185 commented 1 month ago

Hi @

please enable debug logging, restart the integration and download and provide the log file.

Further please download and provide the diagnostics data for this integration.

Note: it is better to drag the log into the comment (which will add it as an attachment) and not copy paste as it is hard to read logs in GitHub.

thx πŸ‘

garrathbond commented 1 month ago

config_entry-pi_hole-efdbe3a96abce1a2771fa194ff77619b.json home-assistant_pi_hole_2024-08-14T09-56-44.708Z.log

hope this what you want

mib1185 commented 1 month ago

the home-assistant_pi_hole_2024-08-14T09-56-44.708Z.log does not contain any logs related to the pi_hole integration, nor the hole lib - did you reload the pi hole integration after you have enabled the debug logging?

garrathbond commented 1 month ago

try these two reloaded this time home-assistant_pi_hole_2024-08-14T11-26-13.073Z.log config_entry-pi_hole-efdbe3a96abce1a2771fa194ff77619b.json

mib1185 commented 1 month ago
2024-08-14 12:25:29.855 DEBUG (MainThread) [hole] {'core_update': False, 'web_update': False, 'FTL_update': False, 'core_current': 'v5.18.3', 'web_current': 'v5.21', 'FTL_current': 'v5.25.2', 'core_latest': '', 'web_latest': '', 'FTL_latest': '', 'core_branch': 'master', 'web_branch': 'master', 'FTL_branch': 'master'}

your pi hole does not return any *_latest version information - will now check, why it shows different in history and current update entity stae

garrathbond commented 1 month ago

Do i need to do something so it does?


From: Michael @.***> Sent: Wednesday, 14 August 2024 14:34 To: home-assistant/core Cc: garrathbond; Author Subject: Re: [home-assistant/core] homeassistant/components/pi_hole (Issue #123804)

2024-08-14 12:25:29.855 DEBUG (MainThread) [hole] {'core_update': False, 'web_update': False, 'FTL_update': False, 'core_current': 'v5.18.3', 'web_current': 'v5.21', 'FTL_current': 'v5.25.2', 'core_latest': '', 'web_latest': '', 'FTL_latest': '', 'core_branch': 'master', 'web_branch': 'master', 'FTL_branch': 'master'}

your pi hole does not return any *_latest version information - will now check, why it shows different in history and current update entity stae β€” Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

mib1185 commented 1 month ago

You can check, if your pi-hole instance is allowed to check for updates via internet (maybe a firewall or your router is blocking something). Nevertheless, I've created a PR, which will fix the update entities in case no latest versions are provided.

garrathbond commented 1 month ago

My pihole is just a straight setup i have changed nothing as far as i know its got full access If there is some where i need to check please advise how i go about it


From: Michael @.***> Sent: Wednesday, 14 August 2024 16:26 To: home-assistant/core Cc: garrathbond; Author Subject: Re: [home-assistant/core] homeassistant/components/pi_hole (Issue #123804)

You can check, if your pi-hole instance is allowed to check for updates via internet (maybe a firewall or your router is blocking something). Nevertheless, I've created a PR, which will fix the update entities in case no latest versions are provided. β€” Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

garrathbond commented 1 month ago

The pi hole itself does inform me when there are updates so i dont think it is restricked


From: Michael @.***> Sent: Wednesday, 14 August 2024 16:26 To: home-assistant/core Cc: garrathbond; Author Subject: Re: [home-assistant/core] homeassistant/components/pi_hole (Issue #123804)

You can check, if your pi-hole instance is allowed to check for updates via internet (maybe a firewall or your router is blocking something). Nevertheless, I've created a PR, which will fix the update entities in case no latest versions are provided. β€” Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

mib1185 commented 1 month ago

since the data are provided by the pi-hole instance itself, an issue at the https://github.com/pi-hole/web repository could clarify it.

garrathbond commented 1 month ago

Really sorry but I don’t know what you are saying

From: Michael @.*** Sent: 14 August 2024 16:57 To: home-assistant/core Cc: Garrath Bond; Author Subject: Re: [home-assistant/core] homeassistant/components/pi_hole (Issue #123804)

since the data are provided by the pi-hole instance itself, an issue at the https://github.com/pi-hole/web repository could clarify it.

β€” Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/123804#issuecomment-2289185917 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AD263T5PNSI2RW24SAMHWNTZRN45DAVCNFSM6AAAAABMN7XPZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZGE4DKOJRG4 . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AD263T53SKS5BWD73IAU6XTZRN45DA5CNFSM6AAAAABMN7XPZ6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUIOI2H2.gif Message ID: @.***>

garrathbond commented 1 month ago

I dont understand whats fixed do i need to do something?

mib1185 commented 1 month ago

The issue report has automatically been closed, since a pull request has been merged, which marks this issue as to be fixed. The fix will be available within the next bugfix release 2024.8.2 (scheduled for this Friday)

garrathbond commented 1 month ago

Ok so is the other one still open when does the bugfix thing happen

From: Michael @.*** Sent: 14 August 2024 23:23 To: home-assistant/core Cc: Garrath Bond; Author Subject: Re: [home-assistant/core] homeassistant/components/pi_hole (Issue #123804)

The issue report has automatically been closed, since a pull request has been merged, which marks this issue as to be fixed. The fix will be available within the next bugfix release 2024.8.2 (scheduled for this Friday)

β€” Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/123804#issuecomment-2290021067 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AD263T6MQ3CFHJ7OJ4KBDCDZRPKFNAVCNFSM6AAAAABMN7XPZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJQGAZDCMBWG4 . You are receiving this because you authored the thread. Message ID: @.***>

mib1185 commented 1 month ago

which other one do you mean?

garrathbond commented 1 month ago

Closed #123804 https://github.com/home-assistant/core/issues/123804 as completed via #123930 https://github.com/home-assistant/core/pull/123930

From: Michael @.*** Sent: 14 August 2024 23:27 To: home-assistant/core Cc: Garrath Bond; Author Subject: Re: [home-assistant/core] homeassistant/components/pi_hole (Issue #123804)

which other one do you mean?

β€” Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/123804#issuecomment-2290025533 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AD263T2H3VTB6J6YKKBYDQTZRPKUFAVCNFSM6AAAAABMN7XPZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJQGAZDKNJTGM . You are receiving this because you authored the thread. Message ID: @.***>

mib1185 commented 1 month ago

this is the current issue - compare the issue numbers from the "CLosed ..." comment and the subject of your mail :wink:

garrathbond commented 1 month ago

Ok if I understand correctly its is still being worked on thanks look forward to the fix

From: Michael @.*** Sent: 14 August 2024 23:34 To: home-assistant/core Cc: Garrath Bond; Author Subject: Re: [home-assistant/core] homeassistant/components/pi_hole (Issue #123804)

this is the current issue - compare the issue numbers from the "CLosed ..." comment and the subject of your mail πŸ˜‰

β€” Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/123804#issuecomment-2290033749 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AD263T26QVFWQTSGWWYFBMLZRPLPDAVCNFSM6AAAAABMN7XPZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJQGAZTGNZUHE . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AD263T4ZMBIXIXBTKWX4RDTZRPLPDA5CNFSM6AAAAABMN7XPZ6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUIP4SFK.gif Message ID: @.***>

mib1185 commented 1 month ago

no, the fix has been merged and will be available with the next bug fix release

garrathbond commented 1 month ago

Oh ok so when is that going to happen


From: Michael @.***> Sent: Thursday, 15 August 2024 01:13 To: home-assistant/core Cc: garrathbond; Author Subject: Re: [home-assistant/core] homeassistant/components/pi_hole (Issue #123804)

no, the fix has been merged and will be available with the next bug fix release β€” Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

abeltman commented 1 month ago

Hi @garrathbond! This is what I think has happened....

There was a temporary glitch at Pi-Hole where they did not show "latest version" info. As a result, the integration in Home Assistant was showing that an update was available. Yesterday, somewhere during the day, I restarted the integration and now all three sensors are showing as normal - Up-to-date

Meanwhile, Michael did create a pull request which has been merged and will be available at the next Core update (I guess). From what I understand, this will fix the issue that when Pi-Hole does not provide "latest version" info the integration will not show the sensors as Update Available (not sure what it will show?)

Having said that... if you reload your integration or restart HA the issue should be fixed since Pi-Hole does provide "latest version". At least it does for me now. If not for you, then maybe something else is wrong (as Michael said...maybe a firewall or your router is blocking something).

Hope this helps and... hope my interpretation of the conversation is correct :). If not, feel free to correct, Michael. Oh... and thanks for the fix!!