search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.48k stars 30.7k forks source link

WLED should have BC with older versions #123975

Closed raress96 closed 2 months ago

raress96 commented 2 months ago

The problem

Hello, this PR breaks compatibility with WLED versions < 0.14.0 which is a very big deal (for me especially): https://github.com/home-assistant/core/pull/122101/files

I have multiple ESP-01 devices running older firmware, some even running custom compiled ones, and it is a pain to upgrade them.

Why is this change needed? Can't BC be added for older versions, since I don't think the basic API has changed that much here.

What version of Home Assistant Core has the issue?

core-2024.8

What was the last working version of Home Assistant Core?

core-2024.7

What type of installation are you running?

Home Assistant OS

Integration causing the issue

WLED

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 2 months ago

Hey there @frenck, mind taking a look at this issue as it has been labeled with an integration (wled) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `wled` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign wled` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

wled documentation wled source (message by IssueLinks)

frenck commented 2 months ago

Why is this change needed?

Because of API changes from WLED. Things like adding support for CCT (from which we know older API versions have issues). The current version the upstream library requires (WLED 0.14.0) is already available for over a year at this point.

../Frenck