home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.42k stars 29.9k forks source link

Roku remote doesn't support ``hold_secs`` #123999

Open PRProd opened 1 month ago

PRProd commented 1 month ago

The problem

When calling the remote.send_command action on a Roku remote entity and specifying a hold_secs value, the hold seems to be ignored. The command is executed as a button press, not instead of a button hold.

What version of Home Assistant Core has the issue?

core-2024.8.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Roku

Link to integration documentation on our website

https://www.home-assistant.io/integrations/roku

Diagnostics information

No response

Example YAML snippet

This is an example of an expected button press and hold when executed from the Home Assistant developer tools

action: remote.send_command
target:
  entity_id: remote.roku_ultra
data:
  num_repeats: 1
  delay_secs: 0
  hold_secs: 1
  command: select

Anything in the logs that might be useful for us?

No response

Additional information

Following the keyup/keydown section from the Roku API page, I can confirm that the following command DOES work.

curl -d '' http://192.168.107.214:8060/keydown/select && sleep 1 && curl -d '' http://192.168.107.214:8060/keyup/select

I have noted this issue over in https://github.com/PRProd/HA-Firemote/discussions/477 under ids 06, 08, and possibly also 11.

It would be awesome to have it resolved before I push that beta into production!

Thanks @ctalkington!

home-assistant[bot] commented 1 month ago

Hey there @ctalkington, mind taking a look at this issue as it has been labeled with an integration (roku) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `roku` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign roku` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


roku documentation roku source (message by IssueLinks)