home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.16k stars 29.83k forks source link

Fujitsu FGLair Integration No device added after configuration (two devices) #124947

Open frangigu opened 2 weeks ago

frangigu commented 2 weeks ago

The problem

Fujitsu FgLair Integration configuration works correctly but once configured no devices are added.

One of my Heatpump does not support Horizontal swing (Vertical only) and it seems like the integration does not manage this case.

Logs added below

What version of Home Assistant Core has the issue?

core-2024.9.0b2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Fujitsu FGLair

Link to integration documentation on our website

https://rc.home-assistant.io/integrations/fujitsu_fglair

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.components.climate
Source: helpers/entity_platform.py:369
integration: Climate (documentation, issues)
First occurred: 15:56:05 (1 occurrences)
Last logged: 15:56:05

Error while setting up fujitsu_fglair platform for climate
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 369, in _async_setup_platform
    await asyncio.gather(*pending)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 628, in async_add_entities
    for entity in new_entities:
  File "/usr/src/homeassistant/homeassistant/components/fujitsu_fglair/climate.py", line 70, in <genexpr>
    FGLairDevice(entry.runtime_data, device)
  File "/usr/src/homeassistant/homeassistant/components/fujitsu_fglair/climate.py", line 112, in __init__
    self._set_attr()
  File "/usr/src/homeassistant/homeassistant/components/fujitsu_fglair/climate.py", line 160, in _set_attr
    self._attr_swing_mode = FUJI_TO_HA_SWING.get(self.device.swing_mode)
                                                 ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/ayla_iot_unofficial/fujitsu_hvac.py", line 309, in swing_mode
    if self.horizontal_swing and self.vertical_swing:
       ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/ayla_iot_unofficial/fujitsu_hvac.py", line 356, in horizontal_swing
    raise SettingNotSupportedError("Device does not support horizontal swing")
ayla_iot_unofficial.fujitsu_hvac.SettingNotSupportedError: Device does not support horizontal swing

Additional information

No response

home-assistant[bot] commented 2 weeks ago

Hey there @crevetor, mind taking a look at this issue as it has been labeled with an integration (fujitsu_fglair) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `fujitsu_fglair` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign fujitsu_fglair` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


fujitsu_fglair documentation fujitsu_fglair source (message by IssueLinks)

crevetor commented 2 weeks ago

@frangigu I see where the problem comes from. It comes from the supporting library. I'll make a PR to fix it.

frangigu commented 2 weeks ago

@frangigu I see where the problem comes from. It comes from the supporting library. I'll make a PR to fix it.

Thanks, appreciated

frangigu commented 1 week ago

@frangigu I see where the problem comes from. It comes from the supporting library. I'll make a PR to fix it.

@crevetor I see you have made a pull request, but is the repository still maintained ? It seems like there is no activity since March on https://github.com/rewardone/ayla-iot-unofficial.

crevetor commented 1 week ago

I have sent an email to the owner, but I didn't get an answer. I'll publish my own version of the package and change the requirements.

rewardone commented 5 days ago

I never saw a direct email (would help if my email was correct (fixed)), but I got the PR over the holiday weekend. Working on it tonight.

Not every project needs frequent commits if it's in a working state :P