home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.57k stars 29.91k forks source link

roborock cannot add device: already_in_progress #125022

Open DemianTinkiel opened 2 weeks ago

DemianTinkiel commented 2 weeks ago

The problem

I was going through the flow and I had a browser crash after putting my email, I received the verification code but I cannot use it because when I try to go through the flow again I get already_in_progress all the time

What version of Home Assistant Core has the issue?

core-2024.8.2

What was the last working version of Home Assistant Core?

core-2024.7.0

What type of installation are you running?

Home Assistant OS

Integration causing the issue

roborock

Link to integration documentation on our website

https://www.home-assistant.io/integrations/roborock

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 2 weeks ago

Hey there @lash-l, mind taking a look at this issue as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `roborock` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign roborock` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


roborock documentation roborock source (message by IssueLinks)

Lash-L commented 2 weeks ago

Try restarting home assistant

DemianTinkiel commented 2 weeks ago

Yes I've done that as a workaround, thanks @Lash-L . However can this be improved for other users? My thinking is that if the request for a validation code was already issued, can we not just progress to the 2nd part of the flow without going through the part of getting the email etc? This would be helpful also towards avoiding roborock throttling the verification code request

Lash-L commented 2 weeks ago

Yes I've done that as a workaround, thanks @Lash-L .

However can this be improved for other users? My thinking is that if the request for a validation code was already issued, can we not just progress to the 2nd part of the flow without going through the part of getting the email etc? This would be helpful also towards avoiding roborock throttling the verification code request

The issue isn't that the validation code was already requested. The issue is that home assistant thinks you are actively setting up the integration elsewhere. When you crashed - it didn't stop the setup I guess.