home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
74.18k stars 31.15k forks source link

continue on error does not continue in parallel script #125159

Open simllll opened 3 months ago

simllll commented 3 months ago

The problem

I have a script that executes 4 things in parallel, one of it is to close the shutters. Somehow, even though it actually works, it reports an error.. the error itself is already kind of strange, because it reports (in red) that there is no error? image

The script stops executing afterwards, even htough I have set "continue_on_error: true": image

Seems like a bug to me, I couldn't find any related bugs, therefore I openend a new report.

What version of Home Assistant Core has the issue?

core-2024.8.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

close shutter / covers during an automation script

Link to integration documentation on our website

https://www.home-assistant.io/integrations/script/ https://www.home-assistant.io/integrations/overkiz/

Diagnostics information

The shutter is controlled via overkitz, I'm not sure if this is the problem though. It should ignore any errors anyways, so I guess the main issue is that "continue_on_error" is not working correctly?

home-assistant_overkiz_2024-09-03T16-59-31.119Z.last3000lines.log

Example YAML snippet

alias: Good Night
sequence:
  - parallel:
      - action: light.turn_off
        metadata: {}
        data: {}
        continue_on_error: true
        target:
          device_id:
            - efecf6d43d2d9849fd2e6a9c7b77f395
            - 1bbc760b2bcb6d7185665165e605b34e
            - c39b090221ddf80d2e76fcc00e7b7593
            - 82e52abde56925206702a47ee8c2699a
            - 2dd130415d18ccaee01d343063c66f6e
      - device_id: ff3ed85d76b1358d7cf442f57e510b3b
        domain: cover
        continue_on_error: true
        entity_id: 2e3ed2148f7d26dfbfce36b5e208ff77
        type: close
      - action: cover.close_cover
        metadata: {}
        data: {}
        continue_on_error: true
        target:
          device_id:
            - 1724f5da13ccb3637dee8a823fd089f0
            - 51fa317563f4ce2e67b0142c46a3932f
            - e38b64f9154e79a2592b8ee0fb3807cf
            - 424fe2d279fa2ba4493091d222dd4157
      - action: tts.speak
        metadata: {}
        continue_on_error: true
        data:
          cache: true
          media_player_entity_id: media_player.schlafzimmer
          message: Gute Nacht
        target:
          entity_id: tts.google_de_at

Anything in the logs that might be useful for us?

Maybe this one?
2024-09-03 18:59:25.991 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved (None)

Additional information

No response

home-assistant[bot] commented 3 months ago

Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (script) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `script` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign script` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


script documentation script source (message by IssueLinks)

Squachen commented 4 weeks ago

Having the same problem that continue_on_error does not work in parallel actions.

jurrienk commented 3 weeks ago

Same :(