home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.71k stars 30.84k forks source link

Android Debug Bridge removes androidtv.adb_command service/action, which breaks automations #125579

Open surfingbytes opened 2 months ago

surfingbytes commented 2 months ago

The problem

There are projectors, such as XGimi Aura, which goes offline when the are turned off. At that moment, the integration Android Debug Bridge removes the projector from home assistant devices/entities, which would be kinda ok. But the problem is, it also removes the service androidtv.adb_command. Having the entity there only when it's reachable is fine, but the service should be there as long as the integration is installed. It's quite different not having a target of a service call (which then works fine if you have continue_on_error on that action), or not having the service at all (which breaks the whole automation even when the offending action has continue_on_error). Please let the service call androidtv.adb_command (or action as it is called now) available as long as the integration is installed. Only the target entity (projector) should be removed when it's not available.

Current behaviour is inconsistent with other HA actions. For example - I don't have any siren entity, but I still have siren.turn_on action available, which is how it should work in this integration too. Disappearing of a target entity should not mean disappearing of the service call itself.

What version of Home Assistant Core has the issue?

core-2024.8.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Android Debug Bridge

Link to integration documentation on our website

https://www.home-assistant.io/integrations/androidtv

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 2 months ago

Hey there @jefflirion, @ollo69, mind taking a look at this issue as it has been labeled with an integration (androidtv) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `androidtv` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign androidtv` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


androidtv documentation androidtv source (message by IssueLinks)