home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.43k stars 30.66k forks source link

Onkyo Integration Broke with 2024.9.0 #125768

Closed Azlinon closed 1 month ago

Azlinon commented 1 month ago

The problem

With the upgrade to 2024.9.0, by onkyo receivers are no longer working with HA. I don't show the resulting entities, existing dashboards with the controls show broken references, etc. The problem persists in 2024.9.1.

As I am experiencing this with two different receiver models, and onkyo-eiscp continues to work for these units, I assume something changed in HA core itself that broke the integration.

What version of Home Assistant Core has the issue?

core-2024.9.1

What was the last working version of Home Assistant Core?

core=2024.8.3

What type of installation are you running?

Home Assistant OS

Integration causing the issue

onkyo

Link to integration documentation on our website

https://www.home-assistant.io/integrations/onkyo/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

I have two units, TX-NR676 and TX-NR7100. In 2024.8.3, the basics worked. On and off before that, I did have issues with disabled zones showing up in HA, but those extra zones were not present immediately before things broke with 2024.9.0.

media_player:

home-assistant[bot] commented 1 month ago

Hey there @arturpragacz, mind taking a look at this issue as it has been labeled with an integration (onkyo) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `onkyo` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign onkyo` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


onkyo documentation onkyo source (message by IssueLinks)

arturpragacz commented 1 month ago

Please post the debug logs.

arturpragacz commented 1 month ago

@home-assistant add-label needs-more-information

reotto613 commented 1 month ago

I am having the same issue. I have the TX-NR555. I did not find any errors in my logs. Here is my debug file, and it is not brining in the Receiver on IP 10.7.96.61. The one at 10.7.96.60 is fine. home-assistant.log

arturpragacz commented 1 month ago

It is interesting that you both have two receivers.

@reotto613 Could you please test it, running only a single receiver? That will tell us whether the problem is with that specific receiver or with the fact that you have multiple.

reotto613 commented 1 month ago

So I pulled the .60 receiver out, and rebooted with debug on and this is what I have.
home-assistant (1).log

arturpragacz commented 1 month ago

Your receiver seems to not answer to the discovery request. Are you sure it is turned on and connected to the network at the correct IP address?

xlemassacre commented 1 month ago

I had the same issue, probably there is a check that didn't exist before 2024.09

I had to allow home assistant network connectivity to port 60128 UDP to the onkyo receiver

arturpragacz commented 1 month ago

@xlemassacre Yes, that is necessary.

Starting from version 2024.9, we assign unique_id to all created media player entities. This is a long awaited change as it allows users to change the name, icon, area, etc. using the Home Assistant UI.

In order to do that though, we have to interview the receiver prior to creating any entities. That communication happens over UDP port 60128.

Azlinon commented 1 month ago

I got back to my machine this morning hoping to pull debug logs, etc. That said, this was absolutely my problem. Thank you!

Prior to this change, everything was running TCP only. I added firewall rules to allow access to these devices via UDP, and these now show up. Given that, I think an integration documentation update could easily handle this.

Ex. Starting in 2024.9, The Onkyo integration requires.....

port X TCP port Y UDP

access from the HA instance to the target devices ....

On Mon, Sep 16, 2024, 08:38 Artur Pragacz @.***> wrote:

@xlemassacre https://github.com/xlemassacre Yes, that is necessary.

Starting from version 2024.9, we assign unique_id to all created media player entities. This is a long awaited change as it allows users to change the name, icon, area, etc. using the Home Assistant UI.

In order to do that though, we have to interview the receiver prior to creating any entities. That communication happens over UDP port 60128.

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/125768#issuecomment-2352801835, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRLHB4HECBDDVOXZGLVQL3ZW3GLBAVCNFSM6AAAAABOBMDLJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJSHAYDCOBTGU . You are receiving this because you authored the thread.Message ID: @.***>

arturpragacz commented 1 month ago

The only documented way to run Home Assistant is on the same network as the devices it connects to. If you have a more complex network setup, it is your own responsibility to make sure all the routing and firewalls are configured correctly.

Also while currently all the receivers seem to use the same TCP port (at least to my knowledge), it is not in fact fixed in the protocol, and it is possible that some future receivers will use a different port.

arturpragacz commented 1 month ago

@home-assistant close