home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.44k stars 30.68k forks source link

Media Extractor Ignoring `format_query` #125958

Open mwaterbu opened 1 month ago

mwaterbu commented 1 month ago

The problem

No matter what is entered for the format_query on the extract_media_url action, "best" is used, and the user input is ignored.

What version of Home Assistant Core has the issue?

core-2024.9.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Media Extractor

Link to integration documentation on our website

https://www.home-assistant.io/integrations/media_extractor

Diagnostics information

No response

Example YAML snippet

action: media_extractor.extract_media_url
data:
  url: https://www.youtube.com/watch?v=dQw4w9WgXcQ
  format_query: bestaudio

Anything in the logs that might be useful for us?

No response

Additional information

From the example YAML above requesting "bestaudio", the url returned should contain itag=140 but it returns itag=18 which is the "best" format. Selecting a specific id, such as "251" also still returns itag=18 instead of itag=251

Please see https://github.com/home-assistant/core/issues/103984#issuecomment-2187334311 for additional details/example

home-assistant[bot] commented 1 month ago

Hey there @joostlek, mind taking a look at this issue as it has been labeled with an integration (media_extractor) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `media_extractor` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign media_extractor` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


media_extractor documentation media_extractor source (message by IssueLinks)