home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.84k stars 30.09k forks source link

Squeezebox Playlist Artist Name Missing #126007

Open annomatik opened 2 weeks ago

annomatik commented 2 weeks ago

The problem

When I play back (any) single track with Media Player with the Squeezebox Integration, I get the album art, the track title and the track artist -- that's good.

image

On the other hand, when I play back playlists, the track artist is missing for all of the tracks that play back -- that's not so good.

image

Please also display the track artist when playing back a playlist. Or better still, let me configure the meta data that should be displayed, maybe even with infos like genre and bpm.

Thanks!

What version of Home Assistant Core has the issue?

2024.9.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Squeezebox

Link to integration documentation on our website

https://www.home-assistant.io/integrations/squeezebox/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 2 weeks ago

Hey there @rajlaud, mind taking a look at this issue as it has been labeled with an integration (squeezebox) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `squeezebox` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign squeezebox` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


squeezebox documentation squeezebox source (message by IssueLinks)

rajlaud commented 1 week ago

I'm able to reproduce this bug, investigating the cause now.

rajlaud commented 1 week ago

Ah, I've figured out what causes this. It is an issue with the frontend. Any time more than one track is queued up in the Squeezebox, it is in playlist mode. But when in playlist mode, the frontend uses the playlist attribute rather than the artist attribute as the secondary title:

https://github.com/home-assistant/frontend/blob/dev/src/data/media-player.ts

I think the right path here is to open an issue in the frontend repository. I've done so here: https://github.com/home-assistant/frontend/pull/22039

annomatik commented 1 week ago

Thank you!

rajlaud commented 2 days ago

The frontend mod has merged. It looks right now. I tested the dev version locally and it shows the artist name under the title just like playing a single track, even when playing a playlist. This issue can be closed.