Matter: Local OTA update does not perform version check?!

fish12345 commented 3 days ago

The problem

It seems like the Matter server does not do a version check, when a local OTA file is placed in addon_configs/core_matter_server/updates.

This is what I've done:

Created .json file at addon_configs/core_matter_server/updates looking like that:

{
"modelVersion": {
"vid": 1234,
"pid": 5678,
"softwareVersion": 10003,
"softwareVersionString": "1.00.03",
"cdVersionNumber": 1,
"softwareVersionValid": true,
"otaUrl": "file:///my_file_1.0.3.ota",
"otaChecksum": "FlDAS3pcGedkHdCCAkUUIJtvJNE/YTtl+ilQPf1+4gc=",
"otaChecksumType": 1,
"minApplicableSoftwareVersion": 1,
"maxApplicableSoftwareVersion": 10002,
"releaseNotesUrl": ""
}
}

Copied my_file_1.0.3.ota to addon_configs/core_matter_server/updates
Restart Matter server (to re-parse .json files)
Triggered update on device using the Matter server Web UI
After update was installed on device, I restarted Matter server once again (probably not needed)
Try to trigger update on device using the Matter server Web UI

The Web UI tells me that an update is available, even though the version is already installed. Here's an excerpt from the Matter server addon's log file:

2024-09-18 13:50:58.958 (MainThread) DEBUG [matter_server.server.device_controller] <Node:8> Check for updates.
2024-09-18 13:50:58.959 (MainThread) INFO [matter_server.server.device_controller] <Node:8> New software update found: 1.00.03 on UpdateSource.LOCAL (current 1.00.03).

Expected behavior: Matter server detects that local version and installed version is the same (or takes minApplicableSoftwareVersion and maxApplicableSoftwareVersion into account). It should tell me that no update is available.

What version of Home Assistant Core has the issue?

core-2024.9.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Matter Server addon v6.5.1

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

2024-09-18 13:50:58.958 (MainThread) DEBUG [matter_server.server.device_controller] <Node:8> Check for updates.
2024-09-18 13:50:58.959 (MainThread) INFO [matter_server.server.device_controller] <Node:8> New software update found: 1.00.03 on UpdateSource.LOCAL (current 1.00.03).



### Additional information

_No response_

home-assistant[bot] commented 3 days ago

Hey there @home-assistant/matter, mind taking a look at this issue as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of `matter` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign matter` Removes the current integration label and assignees on the issue, add the integration domain after the command. - `@home-assistant add-label needs-more-information` Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue. - `@home-assistant remove-label needs-more-information` Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

matter documentation matter source _{^{(message by IssueLinks)}}

marcelveldt commented 3 days ago

Well, it depends if the device itself did update the version in the BasicInformation cluster. Can you confirm if it did that ?

fish12345 commented 3 days ago

Well, it depends if the device itself did update the version in the BasicInformation cluster. Can you confirm if it did that ?

I'd say it looks good, yes:

SoftwareVersion (0x009) = 10003
SoftwareVersionString (0x00a) = "1.00.03"

marcelveldt commented 3 days ago

Hmm, could be an issue with the local updates provider (that is a bit of a hidden feature you discovered) - we'll have a look

marcelveldt commented 2 days ago

Tested it today, works fine on my end. What happens if you click the update button in the Matter server's own UI ?

home-assistant / core